From ccb2d59e4edd52559badbeff9533d5d82be7a819 Mon Sep 17 00:00:00 2001 From: RuiXuqi <90179819+RuiXuqi@users.noreply.github.com> Date: Mon, 5 Oct 2026 01:51:12 +0800 Subject: [PATCH 1/2] Change dev env detection Replace `sun.java.command` `GradleStart` with `net.minecraftforge.gradle.GradleStart.srg.srg-mcp` as the latter is more universal for Gradle plugins --- .../asm/service/mojang/AbstractMixinServiceLaunchWrapper.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/launchwrapper/java/org/spongepowered/asm/service/mojang/AbstractMixinServiceLaunchWrapper.java b/src/launchwrapper/java/org/spongepowered/asm/service/mojang/AbstractMixinServiceLaunchWrapper.java index 49ad9a77..ad879fd3 100644 --- a/src/launchwrapper/java/org/spongepowered/asm/service/mojang/AbstractMixinServiceLaunchWrapper.java +++ b/src/launchwrapper/java/org/spongepowered/asm/service/mojang/AbstractMixinServiceLaunchWrapper.java @@ -66,6 +66,7 @@ */ public abstract class AbstractMixinServiceLaunchWrapper extends MixinServiceAbstract implements ICleanMixinService { + private static final String DEFAULT_RESOURCE_PATH_PROPERTY = "net.minecraftforge.gradle.GradleStart.srg.srg-mcp"; private static final String PROXY = MixinServiceAbstract.MIXIN_PACKAGE + "transformer.Proxy"; private static final String STATE_TWEAKER = MixinServiceAbstract.MIXIN_PACKAGE + "EnvironmentStateTweaker"; @@ -88,7 +89,7 @@ protected void onRefresh() { /** Whether this is a dev (deobfuscated) launch. Default detects Gradle's {@code GradleStart}. */ protected boolean isDevelopment() { - return System.getProperty("sun.java.command", "").contains("GradleStart"); + return System.getProperty(DEFAULT_RESOURCE_PATH_PROPERTY) != null; } /** From 3d47e8e0dfa331ff25c0781457d9bc59c91866e2 Mon Sep 17 00:00:00 2001 From: RuiXuqi <90179819+RuiXuqi@users.noreply.github.com> Date: Mon, 5 Oct 2026 02:04:00 +0800 Subject: [PATCH 2/2] Update javaDoc --- .../asm/service/mojang/AbstractMixinServiceLaunchWrapper.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/launchwrapper/java/org/spongepowered/asm/service/mojang/AbstractMixinServiceLaunchWrapper.java b/src/launchwrapper/java/org/spongepowered/asm/service/mojang/AbstractMixinServiceLaunchWrapper.java index ad879fd3..5c40839d 100644 --- a/src/launchwrapper/java/org/spongepowered/asm/service/mojang/AbstractMixinServiceLaunchWrapper.java +++ b/src/launchwrapper/java/org/spongepowered/asm/service/mojang/AbstractMixinServiceLaunchWrapper.java @@ -87,7 +87,7 @@ public abstract class AbstractMixinServiceLaunchWrapper extends MixinServiceAbst protected void onRefresh() { } - /** Whether this is a dev (deobfuscated) launch. Default detects Gradle's {@code GradleStart}. */ + /** Whether this is a dev (deobfuscated) launch. Default detects {@code net.minecraftforge.gradle.GradleStart.srg.srg-mcp}. */ protected boolean isDevelopment() { return System.getProperty(DEFAULT_RESOURCE_PATH_PROPERTY) != null; }