Skip to content

Commit 1e0ce3a

Browse files
authored
Bump Numpy Version Cap (#803)
Update numpy version cap to allow for numpy 2.0 support.
1 parent 2e9be39 commit 1e0ce3a

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

doc/changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Description
2020
- Python 3.12 is now supported; where available, installed TensorFlow version
2121
is now 2.16.2, PyTorch is 2.7.1.
2222
- Drop Python 3.9 support
23+
- Add Numpy 2.0 support
2324
- Terminate LSF and LSB support
2425
- Implement workaround for Tensorflow that allows RedisAI to build with GCC-14
2526
- Add instructions for installing SmartSim on PML's Scylla
@@ -104,6 +105,9 @@ Detailed Notes
104105
([SmartSim-PR792](https://github.com/CrayLabs/SmartSim/pull/792))
105106
- Address potential type errors in SmartSim.
106107
([SmartSim-PR798](https://github.com/CrayLabs/SmartSim/pull/798))
108+
- Removes an Numpy upper bound in the SmartSim dependency list now that
109+
SmartRedis and supported ML backends support Numpy 2.0.
110+
([SmartSim-PR803](https://github.com/CrayLabs/SmartSim/pull/803))
107111

108112

109113
### 0.8.0

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ class BuildError(Exception):
179179
"pydantic>2",
180180
"pyzmq>=25.1.2",
181181
"pygithub>=2.3.0",
182-
"numpy<2",
182+
"numpy<3.0.0",
183183
"smartredis>=0.6,<0.7",
184184
],
185185
zip_safe=False,

tests/test_controller_metadata_usage.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
from smartsim.entity import Model
1414
from smartsim.settings import RunSettings
1515

16+
pytestmark = pytest.mark.group_b
17+
1618

1719
class _DummyStep:
1820
def __init__(self, metadata_dir: pathlib.Path, entity_name: str) -> None:
@@ -42,7 +44,7 @@ def fake_create_job_step(entity: Model, metadata_dir: pathlib.Path) -> _DummySte
4244
return _DummyStep(metadata_dir, entity.name)
4345

4446
monkeypatch.setattr(controller, "_create_job_step", fake_create_job_step)
45-
monkeypatch.setattr(controller, "_launch_step", lambda step, entity: None)
47+
monkeypatch.setattr(controller, "_launch_step", lambda step, entity, monitor: None)
4648
monkeypatch.setattr(
4749
controller, "symlink_output_files", lambda *args, **kwargs: None
4850
)

0 commit comments

Comments
 (0)