refactor: streamline constructor syntax and improve code readability across event classes and drivers

Author: iqbalhasandev

src/Drivers/AbstractDriver.php

@@ -29,8 +29,7 @@ public function __construct(
         protected array $config,
         protected Dispatcher $events,
         protected LoggerInterface $logger,
-    ) {
-    }
+    ) {}
 
     abstract public function name(): string;
 
@@ -56,6 +55,7 @@ final public function pay(PaymentRequest $request): PaymentResponse
         try {
             $response = $this->executePayment($request, $txn);
             $this->applyResponse($txn, $response);
+
             return $response;
         } catch (Throwable $e) {
             return $this->handleFailure($txn, $e);
@@ -67,6 +67,7 @@ final public function status(Transaction $transaction): StatusResponse
         $response = $this->executeStatus($transaction);
         $transaction->refreshFromStatus($response);
         $this->events->dispatch(new PaymentStatusChecked($transaction, $response));
+
         return $response;
     }
 
@@ -83,6 +84,7 @@ protected function credential(string $key, mixed $default = null): mixed
     protected function baseUrl(): string
     {
         $key = $this->mode() === 'live' ? 'live_url' : 'sandbox_url';
+
         return (string) ($this->config[$key] ?? '');
     }
 
@@ -189,12 +191,14 @@ protected function extractError(Throwable $e): array
                 $e->providerErrorMessage() ?? $e->getMessage(),
             ];
         }
+
         return ['PROVIDER_FAILURE', $e->getMessage()];
     }
 
     protected function throwsExceptions(): bool
     {
         $flag = config('payify.throw_exceptions');
+
         return $flag ?? (bool) config('app.debug');
     }
 

src/Drivers/FakeDriver.php

@@ -17,7 +17,7 @@
 use Illuminate\Http\Request;
 use Illuminate\Support\Str;
 
-class FakeDriver extends AbstractDriver implements SupportsRefund, SupportsHostedCheckout, HandlesWebhook
+class FakeDriver extends AbstractDriver implements HandlesWebhook, SupportsHostedCheckout, SupportsRefund
 {
     public function name(): string
     {

src/Events/PaymentCancelled.php

@@ -11,7 +11,5 @@ class PaymentCancelled
     use Dispatchable;
     use SerializesModels;
 
-    public function __construct(public Transaction $transaction)
-    {
-    }
+    public function __construct(public Transaction $transaction) {}
 }

src/Events/PaymentFailed.php

@@ -15,6 +15,5 @@ public function __construct(
         public Transaction $transaction,
         public string $errorCode,
         public string $errorMessage,
-    ) {
-    }
+    ) {}
 }

src/Events/PaymentInitiated.php

@@ -11,7 +11,5 @@ class PaymentInitiated
     use Dispatchable;
     use SerializesModels;
 
-    public function __construct(public Transaction $transaction)
-    {
-    }
+    public function __construct(public Transaction $transaction) {}
 }

src/Events/PaymentRefunded.php

@@ -15,6 +15,5 @@ class PaymentRefunded
     public function __construct(
         public Transaction $transaction,
         public RefundResponse $refund,
-    ) {
-    }
+    ) {}
 }

src/Events/PaymentStatusChecked.php

@@ -15,6 +15,5 @@ class PaymentStatusChecked
     public function __construct(
         public Transaction $transaction,
         public StatusResponse $status,
-    ) {
-    }
+    ) {}
 }

src/Events/PaymentSucceeded.php

@@ -11,7 +11,5 @@ class PaymentSucceeded
     use Dispatchable;
     use SerializesModels;
 
-    public function __construct(public Transaction $transaction)
-    {
-    }
+    public function __construct(public Transaction $transaction) {}
 }

src/Events/WebhookReceived.php

@@ -15,6 +15,5 @@ class WebhookReceived
     public function __construct(
         public WebhookPayload $payload,
         public ?Transaction $transaction,
-    ) {
-    }
+    ) {}
 }

tests/Feature/Drivers/FakeDriverTest.php

@@ -13,6 +13,7 @@
 use GuzzleHttp\Handler\MockHandler;
 use GuzzleHttp\HandlerStack;
 use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\Log;
 
@@ -75,7 +76,7 @@ function makeFakeDriver(array $config = []): FakeDriver
 
 it('verifies webhooks unconditionally', function () {
     $driver = makeFakeDriver();
-    $req = new \Illuminate\Http\Request(query: [], request: [
+    $req = new Request(query: [], request: [
         'event' => 'payment.succeeded',
         'reference' => 'INV-WH',
         'provider_transaction_id' => 'pay_1',