Lessen feature envy

Author: optionsome

src/main/java/org/opentripplanner/transit/model/network/TripPattern.java

@@ -486,7 +486,7 @@ private boolean containsSameStopsAsOriginalPattern() {
    * Helper method for getting the trip headsign from the {@link TripTimes}.
    */
   private I18NString getTripHeadSignFromTripTimes(TripTimes tripTimes) {
-    return tripTimes != null ? tripTimes.getTrip().getHeadsign() : null;
+    return tripTimes != null ? tripTimes.getTripHeadsign() : null;
   }
 
   /**

src/main/java/org/opentripplanner/transit/model/timetable/TripTimes.java

@@ -212,6 +212,13 @@ public List<String> getHeadsignVias(final int stop) {
     return List.of(headsignVias[stop]);
   }
 
+  /**
+   * @return the whole trip's headsign. Individual stops can have different headsigns.
+   */
+  public I18NString getTripHeadsign() {
+    return trip.getHeadsign();
+  }
+
   /** @return the time in seconds after midnight that the vehicle arrives at the stop. */
   public int getScheduledArrivalTime(final int stop) {
     return scheduledArrivalTimes[stop] + timeShift;