Merge pull request #23338 from Homebrew/fix-version-detection

Fix GitHub release version detection

Author: MikeMcQuaid

Library/Homebrew/formula_auditor.rb

@@ -997,10 +997,11 @@ def audit_stable_version
       current_version_scheme = formula.version_scheme
 
       previous_version_info, base_ref_version_info = committed_version_info
+      return unless (base_ref_version = base_ref_version_info[:version])
 
-      if (base_ref_version = base_ref_version_info[:version]) &&
-         current_version < base_ref_version &&
-         current_version_scheme == previous_version_info[:version_scheme]
+      if current_version == base_ref_version && current_version.to_s != base_ref_version.to_s
+        problem "Stable: version should not change from #{base_ref_version} to #{current_version}"
+      elsif current_version < base_ref_version && current_version_scheme == previous_version_info[:version_scheme]
         problem "Stable: version should not decrease (from #{base_ref_version} to #{current_version})"
       end
     end

Library/Homebrew/test/formula_auditor_spec.rb

@@ -1427,6 +1427,12 @@ class Foo#{foo_version} < Formula
     end
 
     describe "versions" do
+      context "when uncommitted should not change formatting" do
+        before { formula_gsub "foo-1.0.tar.gz", "foo-1.0.0.tar.gz" }
+
+        it { is_expected.to match("Stable: version should not change from 1.0 to 1.0.0") }
+      end
+
       context "when uncommitted should not decrease" do
         before { formula_gsub "foo-1.0.tar.gz", "foo-0.9.tar.gz" }
 

Library/Homebrew/test/version_spec.rb

@@ -691,6 +691,12 @@
         .to be_detected_from("https://wwwlehre.dhbw-stuttgart.de/~sschulz/WORK/E_DOWNLOAD/V_1.9/E.tgz")
     end
 
+    specify "GitHub release tag takes precedence over asset filename" do
+      url = "https://github.com/dvorka-oss/hstr/releases/download/v3.2/hstr-3.2.0-tarball.tgz"
+
+      expect(described_class.detect(url).to_s).to eq("3.2")
+    end
+
     specify "w.x.y.z url-only version style" do
       expect(described_class.new("2.3.2.0"))
         .to be_detected_from("https://github.com/JustArchi/ArchiSteamFarm/releases/download/2.3.2.0/ASF.zip")

Library/Homebrew/version.rb

@@ -388,6 +388,10 @@ def self.parse(spec, detected_from_url: false)
     # e.g. `https://github.com/petdance/ack/tarball/1.93_02`
     UrlParser.new(%r{github\.com/.+/(?:zip|tar)ball/(?:v|\w+-)?((?:\d+[._-])+\d*)$}),
 
+    # GitHub releases
+    # e.g. `https://github.com/foo/bar/releases/download/v1.2/foo-1.2.0.tar.gz`
+    UrlParser.new(%r{github\.com/.+/releases/download/(?:[rvV]_?)?(#{NUMERIC_WITH_DOTS})/}),
+
     # e.g. `https://github.com/erlang/otp/tarball/OTP_R15B01 (erlang style)`
     UrlParser.new(/[_-]([Rr]\d+[AaBb]\d*(?:-\d+)?)/),