Revert "Merge pull request #922 from IABTechLab/trace-auction-winners-to-creatives"

This reverts commit 58706b4, reversing
changes made to 96fec88.

Author: ChristianPavilonis

crates/trusted-server-core/src/auction/formats.rs

@@ -14,7 +14,6 @@ use url::Url;
 use uuid::Uuid;
 
 use crate::auction::context::ContextValue;
-use crate::auction::types::adm_trace_hash;
 use crate::consent::ConsentContext;
 use crate::constants::{HEADER_X_TS_EC_CONSENT, HEADER_X_TS_EIDS, HEADER_X_TS_EIDS_TRUNCATED};
 use crate::creative;
@@ -342,39 +341,6 @@ pub fn convert_to_openrtb_response(
             }));
         };
 
-        // Trace hash over the exact markup delivered to the client (post
-        // sanitize/rewrite) so the client can stamp the rendered creative with
-        // a value that matches this response byte-for-byte. Logged at info so
-        // server logs join against the DOM markers without debug logging.
-        let adm_hash = adm
-            .as_deref()
-            .filter(|markup| !markup.is_empty())
-            .map(adm_trace_hash);
-        if let Some(ref hash) = adm_hash {
-            log::info!(
-                "auction delivered creative: auction_id={} slot_id={} bidder={} crid={:?} adm_hash={}",
-                auction_request.id,
-                slot_id,
-                bid.bidder,
-                bid.creative_id,
-                hash,
-            );
-        }
-        let mut ts_ext = serde_json::Map::new();
-        ts_ext.insert(
-            "auction_id".to_string(),
-            serde_json::Value::String(auction_request.id.clone()),
-        );
-        if let Some(ref hash) = adm_hash {
-            ts_ext.insert(
-                "adm_hash".to_string(),
-                serde_json::Value::String(hash.clone()),
-            );
-        }
-        let mut ext = ext.unwrap_or_default();
-        ext.insert("ts".to_string(), JsonValue::Object(ts_ext));
-        let ext = Some(ext);
-
         let openrtb_bid = OpenRtbBid {
             id: bid
                 .bid_id

crates/trusted-server-core/src/auction/mod.rs

@@ -35,7 +35,6 @@ pub use telemetry::{
 };
 pub use types::{
     AdFormat, AuctionContext, AuctionRequest, AuctionResponse, Bid, BidStatus, MediaType,
-    adm_trace_hash,
 };
 
 /// Type alias for provider builder functions.

crates/trusted-server-core/src/auction/orchestrator.rs

@@ -166,29 +166,6 @@ fn remaining_budget_ms(start: Instant, timeout_ms: u32) -> u32 {
     timeout_ms.saturating_sub(elapsed)
 }
 
-/// Log one structured trace line per winning bid.
-///
-/// Emits the full trace tuple — auction ID, slot, bidder, ad/cache/creative
-/// IDs, and the creative trace hash — so a rendered creative on the page
-/// (carrying the same tuple in its DOM markers) can be joined back to this
-/// auction in server logs.
-fn log_winning_bids(auction_id: &str, winning_bids: &HashMap<String, Bid>) {
-    for (slot_id, bid) in winning_bids {
-        log::info!(
-            "auction winner: auction_id={} slot_id={} bidder={} price={:?} bid_id={:?} ad_id={:?} cache_id={:?} crid={:?} adm_hash={:?}",
-            auction_id,
-            slot_id,
-            bid.bidder,
-            bid.price,
-            bid.bid_id,
-            bid.ad_id,
-            bid.cache_id,
-            bid.creative_id,
-            bid.creative_trace_hash(),
-        );
-    }
-}
-
 fn snapshot_context_request(request: &Request<EdgeBody>) -> Request<EdgeBody> {
     let mut snapshot = Request::new(EdgeBody::empty());
     *snapshot.method_mut() = request.method().clone();
@@ -303,8 +280,6 @@ impl AuctionOrchestrator {
             strategy_name
         );
 
-        log_winning_bids(&request.id, &result.winning_bids);
-
         Ok(OrchestrationResult {
             total_time_ms: start_time.elapsed().as_millis() as u64,
             ..result
@@ -1325,7 +1300,6 @@ impl AuctionOrchestrator {
                             responses.len(),
                         );
                         let winning = self.select_winning_bids(&responses, &floor_prices);
-                        log_winning_bids(&request.id, &winning);
                         return OrchestrationResult {
                             provider_responses: responses,
                             mediator_response: None,
@@ -1443,8 +1417,6 @@ impl AuctionOrchestrator {
             (None, self.select_winning_bids(&responses, &floor_prices))
         };
 
-        log_winning_bids(&request.id, &winning_bids);
-
         OrchestrationResult {
             provider_responses: responses,
             mediator_response,

crates/trusted-server-core/src/auction/types.rs

@@ -313,49 +313,6 @@ impl From<&AuctionResponse> for ProviderSummary {
     }
 }
 
-/// Length of the hex-encoded creative trace hash.
-///
-/// 16 hex chars (64 bits of SHA-256) — short enough for a DOM attribute and a
-/// log field, long enough that collisions across a page's creatives are not a
-/// practical concern for tracing.
-const ADM_TRACE_HASH_LEN: usize = 16;
-
-/// Compute the trace hash for a creative markup string.
-///
-/// The hash is the first [`ADM_TRACE_HASH_LEN`] hex characters of the SHA-256
-/// of the exact bytes handed to the client. It is a correlation key for
-/// tracing a winning bid to the creative rendered on the page — server logs,
-/// the injected bid payload, and DOM markers all carry the same value — not an
-/// integrity mechanism.
-///
-/// # Examples
-///
-/// ```
-/// use trusted_server_core::auction::adm_trace_hash;
-///
-/// let hash = adm_trace_hash("<div>example creative</div>");
-/// assert_eq!(hash.len(), 16);
-/// ```
-#[must_use]
-pub fn adm_trace_hash(adm: &str) -> String {
-    use sha2::{Digest as _, Sha256};
-
-    let digest = Sha256::digest(adm.as_bytes());
-    let mut hex = hex::encode(digest);
-    hex.truncate(ADM_TRACE_HASH_LEN);
-    hex
-}
-
-impl Bid {
-    /// Trace hash of this bid's creative markup, when present.
-    ///
-    /// See [`adm_trace_hash`] for the hash definition.
-    #[must_use]
-    pub fn creative_trace_hash(&self) -> Option<String> {
-        self.creative.as_deref().map(adm_trace_hash)
-    }
-}
-
 /// `OpenRTB` response metadata for the orchestrator.
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct OrchestratorExt {
@@ -451,42 +408,6 @@ mod tests {
         }
     }
 
-    #[test]
-    fn adm_trace_hash_is_sha256_prefix() {
-        // SHA-256("abc") = ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad
-        assert_eq!(
-            adm_trace_hash("abc"),
-            "ba7816bf8f01cfea",
-            "should be the first 16 hex chars of the SHA-256 digest"
-        );
-    }
-
-    #[test]
-    fn adm_trace_hash_distinguishes_creatives() {
-        assert_ne!(
-            adm_trace_hash("<div>creative a</div>"),
-            adm_trace_hash("<div>creative b</div>"),
-            "should produce different hashes for different markup"
-        );
-    }
-
-    #[test]
-    fn creative_trace_hash_follows_creative_presence() {
-        let mut bid = make_bid("kargo");
-        assert_eq!(
-            bid.creative_trace_hash(),
-            None,
-            "should be None without creative markup"
-        );
-
-        bid.creative = Some("<div>example creative</div>".to_owned());
-        assert_eq!(
-            bid.creative_trace_hash(),
-            Some(adm_trace_hash("<div>example creative</div>")),
-            "should hash the creative markup when present"
-        );
-    }
-
     #[test]
     fn provider_summary_from_successful_response() {
         let response = AuctionResponse::success(

crates/trusted-server-core/src/integrations/prebid.rs

@@ -6844,49 +6844,6 @@ set = { networkId = 42 }
         );
     }
 
-    #[test]
-    fn parse_bid_extracts_crid() {
-        let bid_json = serde_json::json!({
-            "id": "bid-id-321",
-            "impid": "atf_sidebar_ad",
-            "price": 1.25,
-            "adm": "<div>ad</div>",
-            "crid": "cr-98765",
-            "w": 300,
-            "h": 250
-        });
-        let provider = PrebidAuctionProvider::new(base_config());
-        let bid = provider
-            .parse_bid(&bid_json, "kargo")
-            .expect("should parse bid");
-        assert_eq!(
-            bid.creative_id.as_deref(),
-            Some("cr-98765"),
-            "should extract the OpenRTB creative ID"
-        );
-        assert_eq!(
-            bid.bid_id.as_deref(),
-            Some("bid-id-321"),
-            "should extract the OpenRTB bid ID"
-        );
-    }
-
-    #[test]
-    fn parse_bid_sets_crid_to_none_when_absent() {
-        let bid_json = serde_json::json!({
-            "id": "bid-id-322",
-            "impid": "atf_sidebar_ad",
-            "price": 1.25,
-            "w": 300,
-            "h": 250
-        });
-        let provider = PrebidAuctionProvider::new(base_config());
-        let bid = provider
-            .parse_bid(&bid_json, "kargo")
-            .expect("should parse bid");
-        assert!(bid.creative_id.is_none(), "should be None when crid absent");
-    }
-
     #[test]
     fn parse_bid_sets_cache_fields_to_none_when_no_cache_entry() {
         let bid_json = serde_json::json!({