Repository navigation
Delete split_index, sync experimental/deprecated method docs with current src - #362
Merged
Merged
Conversation
- Drop the `replaceinds(tn::AbstractITensorNetwork, is_is′::Pair{<:IndsNetwork, <:IndsNetwork})`
entry from `experimental_methods.md` — the method has already been
removed from `src/`.
- Move `split_index(tn::AbstractITensorNetwork, edges_to_split; ...)` from
`experimental_methods.md` to `deprecated_methods.md`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
- Coverage 74.59% 74.52% -0.07%
==========================================
Files 63 63
Lines 2944 2936 -8
==========================================
- Hits 2196 2188 -8
Misses 748 748
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Inline the single test-suite usage (prime the ket-side shared bra-ket indices at selected vertices) so the helper is no longer needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mtfishman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
split_index(tn::AbstractITensorNetwork, edges_to_split; ...). Its single test-suite usage (priming the ket-side shared bra-ket indices at selected vertices) is inlined where it was used.replaceinds(tn::AbstractITensorNetwork, ::Pair{<:IndsNetwork, <:IndsNetwork})entry fromexperimental_methods.md— the method had already been removed fromsrc/and the doc was stale.Targeting the v0.22 release line via the existing
0.22.0-DEVaccumulator (already a breaking bump).