Skip to content

Commit 513a57b

Browse files
chen2021673chen2021673
committed
fix: separate launcher args from model test args
1 parent 169c6b5 commit 513a57b

2 files changed

Lines changed: 4 additions & 11 deletions

File tree

‎scripts/run_models_and_profile.bash‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ for ((id=0; id<num_basic_compile_commands; ++id)); do
522522

523523
for ((ti=0; ti<num_tests; ++ti)); do
524524
test_id=$(jq -r ".test_groups[$gi].tests[$ti].id" "$CONFIG_FILE")
525-
nproc_per_node="$(jq -r ".test_groups[$gi].tests[$ti].args.nproc_per_node // empty" "$CONFIG_FILE")"
525+
nproc_per_node="$(jq -r ".test_groups[$gi].launcher_args.nproc_per_node // empty" "$CONFIG_FILE")"
526526
: "${nproc_per_node:=${INFINI_NPROC_PER_NODE:-1}}"
527527
if tag_enabled_for_model "$group_tag" "$GPT2_TEST_GROUPS"; then
528528
LORA_WEIGHTS_DIR="$GPT2_LORA_WEIGHTS_DIR"

‎scripts/test_config.json‎

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -898,12 +898,14 @@
898898
},
899899
{
900900
"tag": "8_proc",
901+
"launcher_args": {
902+
"nproc_per_node": 8
903+
},
901904
"tests": [
902905
{
903906
"id": "3",
904907
"args": {
905908
"dtype": "float32",
906-
"nproc_per_node": 8,
907909
"nthread_per_process": 1,
908910
"num_iteration": 10,
909911
"batch_size": 10,
@@ -914,7 +916,6 @@
914916
"id": "3_bfloat16",
915917
"args": {
916918
"dtype": "bfloat16",
917-
"nproc_per_node": 8,
918919
"nthread_per_process": 1,
919920
"num_iteration": 10,
920921
"batch_size": 10,
@@ -925,7 +926,6 @@
925926
"id": "4",
926927
"args": {
927928
"dtype": "float32",
928-
"nproc_per_node": 8,
929929
"nthread_per_process": 1,
930930
"num_iteration": 10,
931931
"batch_size": 40,
@@ -937,7 +937,6 @@
937937
"id": "4_bfloat16",
938938
"args": {
939939
"dtype": "bfloat16",
940-
"nproc_per_node": 8,
941940
"nthread_per_process": 1,
942941
"num_iteration": 10,
943942
"batch_size": 40,
@@ -949,7 +948,6 @@
949948
"id": "5",
950949
"args": {
951950
"dtype": "float32",
952-
"nproc_per_node": 8,
953951
"nthread_per_process": 1,
954952
"num_iteration": 10,
955953
"batch_size": 40,
@@ -962,7 +960,6 @@
962960
"id": "5_bfloat16",
963961
"args": {
964962
"dtype": "bfloat16",
965-
"nproc_per_node": 8,
966963
"nthread_per_process": 1,
967964
"num_iteration": 10,
968965
"batch_size": 40,
@@ -975,7 +972,6 @@
975972
"id": "6",
976973
"args": {
977974
"dtype": "float32",
978-
"nproc_per_node": 8,
979975
"nthread_per_process": 1,
980976
"num_iteration": 10,
981977
"batch_size": 10,
@@ -987,7 +983,6 @@
987983
"id": "6_bfloat16",
988984
"args": {
989985
"dtype": "bfloat16",
990-
"nproc_per_node": 8,
991986
"nthread_per_process": 1,
992987
"num_iteration": 10,
993988
"batch_size": 10,
@@ -999,7 +994,6 @@
999994
"id": "8",
1000995
"args": {
1001996
"dtype": "float32",
1002-
"nproc_per_node": 8,
1003997
"nthread_per_process": 1,
1004998
"num_iteration": 10,
1005999
"batch_size": 40,
@@ -1014,7 +1008,6 @@
10141008
"id": "8_bfloat16",
10151009
"args": {
10161010
"dtype": "bfloat16",
1017-
"nproc_per_node": 8,
10181011
"nthread_per_process": 1,
10191012
"num_iteration": 10,
10201013
"batch_size": 40,

0 commit comments

Comments
 (0)