Repository navigation
Replies: 2 comments
|
@robertocarlous: step 2 is done. The upstream You're clear to do steps 1 and 3:
#29 and #72 still show their old commit/file counts. GitHub hasn't recomputed them against the new base yet, and they should reflect it once you push. After step 3, #29's diff against This is also tracked as task_240926_16 Part C0. |
|
Closing: the consolidation is done. Checked on Nov 8 against PR No. 29's head
Two things are left for PR No. 29's next review, both tracked under Discussion No. 163. First, |
Uh oh!
There was an error while loading. Please reload this page.
@robertocarlous: proposal to consolidate the indexer work into a single PR before the #153 subgraph handlers land on it (task_240926_16 Part C).
Where things stand
Checked 2026-09-24 against
develop@d321c2a.robertocarlous:feat/din-indexer@866521a(2026-07-14)feat/din-indexerrobertocarlous:feat/din-indexer-65@1a2a877(2026-08-04)feat/din-indexer2b015f5: documents the 1000-result GraphQL cap and addssubgraph/scripts/update-subgraph-addresses.sh.1a2a877: wires the P3-staking events into the subgraph (ValidatorJailed/Reactivated,MinStakeUpdated,ModelStakeBoundsUpdated,MaxConcurrentRegistrationsPerStakeUnitUpdated,JailEvententity).origin/feat/p3-stakingmerge (ecdd87b), and every one of them is already ondevelop. That's why feat(indexer): wire P3-staking events — ValidatorJailed/Reactivated, governable MIN_STAKE, JailEvent entity #72 shows 185 files. Its real diff is small.feat/din-indexeris 230 commits behinddevelop. It's a strict ancestor, so it can fast-forward.developinto feat(indexer): wire P3-staking events — ValidatorJailed/Reactivated, governable MIN_STAKE, JailEvent entity #72's head is conflict-free (checked withgit merge-tree). After that, the only non-subgraph/differences fromdevelopare 4 files:Developer/issues/indexer.mdDocumentation/technical/audits/task-contract-event-audit.mddincli/cli/dindao.pytests/test_list_pending_requests.pysubgraph.yamlhandles still matchdevelop'sDinValidatorStake(ValidatorSlashed,ValidatorJailed,ModelStakeBoundsUpdated, etc.).Proposed steps
git checkout feat/din-indexer && git merge --ff-only feat/din-indexer-65 && git push.feat/din-indexertodevelop, so feat(indexer): implement DIN Protocol subgraph — platform + task-level contracts #29's diff only shows indexer changes rather than 230 commits ofdevelophistory.develop.developinto yourfeat/din-indexer. It should be conflict-free, as noted above.subgraph/abis/from currentdevelopcontracts, and re-check thatgraph codegen && graph buildpasses.GIstatesenum-mapping regeneration, theRewardDepositedhandler, and theETHTreasuryWithdrawnstub go on as further commits to feat(indexer): implement DIN Protocol subgraph — platform + task-level contracts #29, not as a separate PR.Coverage gaps to note (not blocking the consolidation)
DinValidatorStakeondevelopnow emits several events that #72 doesn't handle yet:UnbondingPeriodUpdatedSlashTreasuryUpdatedEncryptionKeyRegisteredActiveRegistrationIncremented/DecrementedS5RecidivismParamsUpdated,ValidatorEscalatedS5,S6ParamsUpdated,S6NoParticipationRecorded,S6PartialSlashFiredWorth a pass once step 3 is done. Doing it in the same refresh is fine if it's small; otherwise list it in #29's description as a follow-up.
Related: #24 (Start DIN-Indexer), #153 (task-level events), task_240926_16 Part C.
All reactions