task_061026_21 — Full-GI Alignment: Contracts Check + Richer GI States, dincli Commands, Integration Suite on Foundry, GI Docs (#223) (Umer Majeed)

[umermjd11]

cc @umeradl. This is the tracking discussion for task_061026_21.

Full spec: Developer/tasks/task_061026_21.md. It lands with the forwarding PR. The source plan is task-plan-051026-2, reviewed in PR #229 (verification, decisions, decisions applied).

Timeline

Oct 6 – Oct 17, 2026 (about 8.5 working days). The Parts run in order A → B → C → D → E: contracts check → richer GI states → dincli → integration suite → docs. That way the commands and the suite are built on the final state machine.

Why

On develop, nobody can run a DevNet 2.0 GI from dincli:

• model-owner deploy sends the old constructors.
• There are no commands to wire the DIN token, fund the reward pool (so gi start reverts), register auditor keys (so test data can't be assigned), claim, release slots or dispute.

The tests/dincli full-GI suite can't pass with either toolchain:

• It fails Phase 1 on a proxyAdmin key.
• It deploys the old hardhat task contracts.
• It overwrites the tracked ABIs.
• It never funds, keys or reveals.

The public GI docs are stale.

Parts

Part	PR	Summary	Estimate
A	with B	Contracts check: GI preconditions and a dincli coverage table, recorded in the spec. Two text fixes	0.5 d
B	PR 1	New states AuditSeedLocked, AuditTestDataAssigned and AggSeedLocked. AuditTestDataAssigned requires every batch to have a test-data commitment, which closes the gap where evaluation could start without test data. New ordinals go to PR #29	1.5 d
C	PR 2, closes #223	deploy --model-id + setDinToken, a modelId check at approval, rewards deposit / fund-emission / claim / withdraw, a per-wallet auditor register-encryption-key, gi release-slots, both dispute families, and fail-fast checks	3 d
D	PR 3	tests/dincli on foundry artifacts runs one complete GI: funding, keys, seed locks, three commit/reveal phases, slash, end, claims and release slots. State is asserted after every phase	2 d
E	PR 4	GI docs: model-workflow, the role guides, getting-started, setup.md (broken install line), din-workflow, ROADMAP.md:19, the DINShared diagram and CLAUDE.md	1.5 d

Decisions (resolved on PR #229)

1. States: all three, in priority order AuditTestDataAssigned > AuditSeedLocked > AggSeedLocked if the coordinator's 1,079 B margin runs short. The commitment check adds +75 B to DINTaskAuditor, counted in task_061026_20's shared budget.
2. modelId check: in dincli at approval, with --force. A registry-side check is a mainnet follow-up (BL-34 / Three dormant/no-op mechanisms awaiting a product decision: disableModel kill-switch, rejectModel fee handling, S6 slashing (M-2, L-4, BL-31) #224).
3. Suite: one complete GI. A second GI is an optional slow test, kept out of CI.
4. Disputes: in Part C, built against the PR fix(task-auditor): close the test-data dispute reward-pool drain (#205) #215 dispute shape.

Follow-ups and interplay

• #228: run the suite in its own CI job once Part D passes. Not part of this task.
• Discussion #216: its follow-ups are all mapped to Parts C and E in the spec.
• task_061026_20: shares DINShared.sol, the DINTaskAuditor ABI and its byte budget. Both specs have a coordination section.

Post progress updates, questions and PR links here. If anything in the spec is unclear or doesn't look right, comment here and cc @umeradl.

🤖 Generated with Claude Code

[umermjd11]

Spec PR: #232. It adds this task's spec, the companion task, and closes task_021026_19.

[umermjd11]

PRs raised:

PR	Covers	Status
No. 272	Parts A + B (richer GI states)	Merged, then reverted in No. 273
No. 287	Parts A + B, re-land	Approved, not merged yet
No. 302	Part C (dincli commands; closes BL-28, No. 223 Part 2)	Open, review requested. CI OK green; 609 unit tests pass
Part D (integration suite on foundry)	—	Not raised yet. Needs Part C
Part E (GI docs)	—	Not raised yet. Comes last

Notes on No. 302:

• Deploy is left to No. 261. Deploy --model-id (BL-27, No. 223 Part 1) is in robertocarlous's No. 261. Once it merges, a small follow-up adds setDinToken, the totalModels() default and the NameError fix.
• Order with No. 287. Nothing in No. 302 depends on Part B's new states. They overlap only in auditor_batches.py, in different hunks, so whichever merges second rebases.
• The red "Integration (full GI)" check is expected. That suite can't pass until Part D, and No. 301 makes it a manual-only workflow.

[abrahamnash]

@umermjd11 a question that came up while reviewing #287, separate from that PR (which I've approved):

assignAuditTestDataset (DINTaskAuditor) checks onlyOwner, onlyCurrentGI and pendingReassignment, but not the GI state. As far as I can see, the owner could still overwrite a batch's test data, and its commitment, after AuditTestDataAssigned or once evaluation has started. That was true before #287 too, so it's not a reason to hold it.

I couldn't find it in Parts C–E of task_061026_21. Should assignAuditTestDataset be limited to AuditorsBatchesCreated, leaving reassignAuditTestDataset as the only route for changes after that (through a dispute)? If so, should it go into this task, or into a separate issue?