simplify verifyPoP with less FFI calls

Author: perturbing

cardano-crypto-class/src/Cardano/Crypto/DSIGN/BLS12381/Internal.hs

@@ -85,12 +85,9 @@ import Cardano.Crypto.EllipticCurve.BLS12_381.Internal (
   ScalarPtr (..),
   blsAddOrDouble,
   blsCompress,
-  blsGenerator,
-  blsHash,
   blsIsInf,
   blsUncompress,
   c_blst_keygen,
-  finalVerifyPairs,
   mkBLSTError,
   scalarFromBS,
   scalarToBS,
@@ -108,6 +105,7 @@ import Cardano.Crypto.PinnedSizedBytes (
 import Cardano.Crypto.Seed (getBytesFromSeedT)
 import Cardano.Crypto.Util (SignableRepresentation (getSignableRepresentation))
 import Control.DeepSeq (NFData)
+import Data.Bifunctor (first)
 import Data.ByteString (ByteString)
 import qualified Data.ByteString as BS
 import Data.ByteString.Unsafe (unsafeUseAsCStringLen)
@@ -530,10 +528,10 @@ instance
         SigBLS12381 sig = signDSIGN ctx (rawSerialiseVerKeyDSIGN vk) sk
      in PossessionProofBLS12381 sig
   {-# INLINE verifyPossessionProofDSIGN #-}
-  verifyPossessionProofDSIGN BLS12381SignContext {blsSignContextDst = dst, blsSignContextAug = aug} (VerKeyBLS12381 vk) (PossessionProofBLS12381 mu1Psb) =
-    if finalVerifyPairs @curve (blsGenerator, mu1Psb) (vk, blsHash (blsCompress vk) dst aug)
-      then Right ()
-      else Left "verifyPossessionProofDSIGN: BLS12381DSIGN failed to verify."
+  verifyPossessionProofDSIGN ctx vk (PossessionProofBLS12381 mu1Psb) =
+    first
+      (const "verifyPossessionProofDSIGN: BLS12381DSIGN failed to verify.")
+      (verifyDSIGN ctx vk (rawSerialiseVerKeyDSIGN vk) (SigBLS12381 mu1Psb))
   {-# INLINE rawSerialisePossessionProofDSIGN #-}
   rawSerialisePossessionProofDSIGN (PossessionProofBLS12381 mu1Psb) =
     blsCompress @(DualCurve curve) mu1Psb