Skip to content

Test kernels that spill past 128 KB of scratch - #763

Merged
maleadt merged 1 commit into
mainfrom
tb/igc-spill-tests
Nov 8, 2026
Merged

maleadt merged 1 commit into
mainfrom
tb/igc-spill-tests

Conversation

@maleadt

@maleadt maleadt commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Adds a regression test for two IGC miscompilations on Gen12LP (Tiger Lake, DG1, Alder Lake, ...) that corrupted kernels spilling a lot of registers:

Both are fixed in libigc_jll 2.41.5+4 (JuliaPackaging/Yggdrasil#15504), which also includes a fix for intel/intel-graphics-compiler#472 (OWord spills of indirectly accessed registers used the wrong slot, which hung the GPU in AcceleratedKernels.jl's tests). I couldn't trigger that one from Julia in a compact test.

No compat bump is needed: libigc_jll comes in through NEO_jll, which doesn't pin its build, so a fresh resolve picks the latest one, 2.41.5+4 (existing environments may need Pkg.update()). On a Tiger Lake with 2.41.5+2 both test cases fail; with 2.41.5+4 they pass (about 40 s, mostly compilation). The test needs a device that supports a sub-group size of 32 and is skipped otherwise.

On Gen12LP, IGC corrupted such spills: HWord scratch offsets wrapped around past 128 KB (intel/intel-graphics-compiler#469), and with at least 60% of 128 KB of private memory the post-RA spill/fill propagation dropped OWord spills (intel/intel-graphics-compiler#471). Both are fixed in libigc_jll 2.41.5+4.
@codecov

codecov Bot commented Nov 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.81%. Comparing base (2b1d898) to head (2c39de5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   87.02%   86.81%   -0.21%     
==========================================
  Files          55       55              
  Lines        5193     5135      -58     
==========================================
- Hits         4519     4458      -61     
- Misses        674      677       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt
maleadt merged commit ebbaa28 into main Nov 8, 2026
5 checks passed
@maleadt
maleadt deleted the tb/igc-spill-tests branch November 8, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant