From eb856fc356eea7aa2c0eab2dc7b82a12a137f34e Mon Sep 17 00:00:00 2001 From: Michael Dibbets Date: Mon, 28 Sep 2026 16:56:39 +0200 Subject: [PATCH 1/2] fix: Nest Loki_Base::config ACL resource under Stores > Configuration Loki_Base::config was declared at the top level of the ACL tree, next to Magento_Backend::all and Magento_Backend::admin. Magento core locates the admin subtree by position: Magento\Integration\Model\Config\Consolidated\Converter reads $allResources[1]['children'], assuming the top level is exactly [Magento_Backend::all (10), Magento_Backend::admin (20)]. With sortOrder 10, Loki_Base::config lands among them and pushes admin off index 1, so the converter hashes the wrong subtree and integration.xml resources stop resolving for every integration in the store. A top-level resource is also invisible in the role editor, which only shows the admin subtree, so restricted admin roles could never be granted access to the Loki Base config section. The resource now sits under Magento_Config::config, where core declares its own config-section resources. The id is unchanged, so system.xml and saved role rules keep working. --- CHANGELOG.md | 1 + etc/acl.xml | 10 +++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 252ecef..717f98a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Fixed +- ACL resource `Loki_Base::config` is now nested under Stores > Configuration instead of sitting at the top level next to `Magento_Backend::admin`, which broke integration ACL resolution and hid it from restricted admin roles - `MageCookies.getAll()` no longer truncates cookie values containing `=` (e.g. Cookiebot `CookieConsent`) - Playwright test no longer depends on a checkout or catalog product (fails in CI) - `script-container.phtml` fatal "Undefined variable $childRenderer" when `Loki_Components` is not installed: `LokiScript` now assigns its own `ChildRenderer` diff --git a/etc/acl.xml b/etc/acl.xml index e7ebb5a..9ee70bf 100644 --- a/etc/acl.xml +++ b/etc/acl.xml @@ -2,7 +2,15 @@ - + + + + + + + + + From ab8121dba180191f0eb62fd3b0ab00c96383ebef Mon Sep 17 00:00:00 2001 From: Michael Dibbets Date: Mon, 28 Sep 2026 17:14:06 +0200 Subject: [PATCH 2/2] fix: Hang Loki_Base::config directly under Magento_Backend::admin Nesting it four levels deep under Magento_Config::config was more than the fix needs. What matters is that it is no longer a top-level sibling of Magento_Backend::admin; one level under admin is enough to keep admin at index 1 and to make the resource grantable in the role editor. --- CHANGELOG.md | 2 +- etc/acl.xml | 8 +------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 717f98a..7ffd523 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Fixed -- ACL resource `Loki_Base::config` is now nested under Stores > Configuration instead of sitting at the top level next to `Magento_Backend::admin`, which broke integration ACL resolution and hid it from restricted admin roles +- ACL resource `Loki_Base::config` is now a child of `Magento_Backend::admin` instead of a top-level sibling of it, which broke integration ACL resolution and hid it from restricted admin roles - `MageCookies.getAll()` no longer truncates cookie values containing `=` (e.g. Cookiebot `CookieConsent`) - Playwright test no longer depends on a checkout or catalog product (fails in CI) - `script-container.phtml` fatal "Undefined variable $childRenderer" when `Loki_Components` is not installed: `LokiScript` now assigns its own `ChildRenderer` diff --git a/etc/acl.xml b/etc/acl.xml index 9ee70bf..91705a4 100644 --- a/etc/acl.xml +++ b/etc/acl.xml @@ -3,13 +3,7 @@ - - - - - - - +