Skip to content

Commit 0dabc47

Browse files
Fix closeable plain text handling (#2918)
1 parent f1943ee commit 0dabc47

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import closeable from '../directives/Closeable';
2+
3+
describe('Closeable directive', () => {
4+
test('preserves plain text content', () => {
5+
const element = document.createElement('div');
6+
element.textContent = 'Plain text';
7+
8+
closeable.mounted(element);
9+
10+
expect(element.querySelector('.content').textContent).toBe('Plain text');
11+
});
12+
});

packages/vue-components/src/directives/Closeable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ module.exports = {
5151

5252
const content = document.createElement('div');
5353
content.classList.add('content');
54-
Array.from(el.children).forEach(child => content.append(child));
54+
Array.from(el.childNodes).forEach(child => content.append(child));
5555
el.replaceChildren();
5656
el.append(content);
5757
el.classList.add('closeable-wrapper');

0 commit comments

Comments
 (0)