Skip to content

Commit 71464d9

Browse files
committed
Fixes for unobfuscated minecraft
1 parent 34c8762 commit 71464d9

7 files changed

Lines changed: 21 additions & 9 deletions

File tree

src/main/groovy/net/minecraftforge/forgedev/ForgeDevExtension.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,8 +454,10 @@ public BinaryPatches binaryPatches(String name) {
454454
});
455455
ret.create(task -> {
456456
task.getClean().setFrom(this.base.getClasses());
457-
task.getSrg().setFrom(this.base.getMap2Srg());
458-
task.getReverseSrg().set(true);
457+
if (Util.isObfuscated(this.base.getMcpVersion().get())) {
458+
task.getSrg().setFrom(this.base.getMap2Srg());
459+
task.getReverseSrg().set(true);
460+
}
459461
task.getSas().setFrom(this.base.getSideAnnotationStrippers());
460462
task.getDirty().setFrom(this.project.getTasks().named("jar"));
461463
});

src/main/groovy/net/minecraftforge/forgedev/Tools.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public final class Tools {
1010
private Tools() { }
1111

1212
// EXECUTABLE
13-
public static final Tool MAVENIZER = Tool.ofForge("mavenizer", "net.minecraftforge:minecraft-mavenizer:0.4.58", 25);
13+
public static final Tool MAVENIZER = Tool.ofForge("mavenizer", "net.minecraftforge:minecraft-mavenizer:0.5.15", 25);
1414
public static final Tool DIFFPATCH = Tool.of("diffpatch", "io.codechicken:DiffPatch:2.1.0.42:all", Constants.MAVEN_CENTRAL, 8);
1515
public static final Tool BINPATCH = Tool.ofForge("binpatcher", "net.minecraftforge:binarypatcher:1.3.3:fatjar", 8);
1616
public static final Tool INSTALLERTOOLS = Tool.ofForge("installertools", "net.minecraftforge:installertools:1.4.4:fatjar", 8);

src/main/groovy/net/minecraftforge/forgedev/Util.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,8 @@ public static String iso8601Now() {
178178
}
179179

180180
public static String iso8601(Date self) {
181-
var format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ");
182-
var result = format.format(self);
183-
return result.substring(0, 22) + ':' + result.substring(22);
181+
var format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssXXX");
182+
return format.format(self);
184183
}
185184

186185
public static <R extends HasConfigurableValue> R finalize(Project project, R ret) {

src/main/groovy/net/minecraftforge/forgedev/base/MCPBaseImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public Provider<File> getMap2Srg() {
9797

9898
@Override
9999
public Provider<File> getClasses() {
100-
return this.mavenizer.getClasses().orElse(this.getClassesRaw());
100+
return this.mavenizer.getClasses();
101101
}
102102

103103
@Override

src/main/groovy/net/minecraftforge/forgedev/tasks/userdev/UserDev.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,10 @@ public void base(PatcherBase base) {
122122
private void configureBinaryPatches(CreateBinPatches task) {
123123
if (this.patcherBase instanceof MCPBase mcp) {
124124
task.getClean().setFrom(mcp.getClasses());
125-
task.getSrg().setFrom(mcp.getMap2Srg());
126-
task.getReverseSrg().set(true);
125+
if (Util.isObfuscated(mcp.getMcpVersion().get())) {
126+
task.getSrg().setFrom(mcp.getMap2Srg());
127+
task.getReverseSrg().set(true);
128+
}
127129
task.getSas().setFrom(mcp.getSideAnnotationStrippers());
128130
task.getDirty().setFrom(this.project.getTasks().named("jar"));
129131
}

src/main/groovy/net/minecraftforge/forgedev/values/MCPData.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,11 @@ public Provider<File> getMap2Srg() {
110110
}
111111

112112
public Provider<File> getClasses() {
113+
return this.optional("classes.srg").orElse(get("classes.raw")).map( path ->
114+
getOutputDir() == null ? project.file(path) : new File(getOutputDir(), path)
115+
);
116+
}
117+
public Provider<File> getClassesSrg() {
113118
return getFile("classes.srg");
114119
}
115120
public Provider<File> getClassesRaw() {

src/main/groovy/net/minecraftforge/forgedev/values/MavenizerData.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,10 @@ public MavenizerData(final Project project, final ForgeDevPlugin plugin) {
5757
return null;
5858
}
5959

60+
protected Provider<String> optional(String key) {
61+
return this.data.getting(key);
62+
}
63+
6064
protected Provider<String> get(String key) {
6165
return this.data.getting(key).orElse(getProviders().provider(() -> {
6266
throw new IllegalStateException("Mavenizer did not output expected json data " + key);

0 commit comments

Comments
 (0)