test(live): auto-retry two flaky production UI tests

test_failed_job_error_visible_in_ui and test_my_models_page_renders
both failed on b45e10b's CI run due to transient production blips
(empty page bodies on an authenticated page), unrelated to that
commit's RAST retry-window change. Wire the existing but unused
flaky_external marker to pytest-rerunfailures (one retry, 5s delay)
via the pytest_collection_modifyitems hook in tests/live/conftest.py,
and apply the marker to just those two tests.

Also fix test_error_translation.py test_504_all_attempts_fails_with_original_exception,
broken by b45e10b's _MAX_RETRIES bump (3 -> 5): it hardcoded a
2-element _BACKOFF_SECONDS tuple, which is now too short and causes
an IndexError on the later retry attempts instead of the exception
under test. Size the tuple from the real _MAX_RETRIES instead.

Author: jplfaria

tests/live/conftest.py

@@ -328,3 +328,8 @@ def pytest_collection_modifyitems(config, items) -> None:  # noqa: D401
             if part in dir_to_marker:
                 item.add_marker(getattr(pytest.mark, dir_to_marker[part]))
                 break
+        # Tests marked flaky_external (production/PATRIC/BV-BRC/SOLR
+        # instability, not our bug) get one automatic retry via
+        # pytest-rerunfailures instead of failing the whole run outright.
+        if item.get_closest_marker("flaky_external") is not None:
+            item.add_marker(pytest.mark.flaky(reruns=1, reruns_delay=5))

tests/live/ui/test_failed_job_error_display.py

@@ -66,6 +66,7 @@ def _wait_for_failure(api_url: str, token: str, job_id: str, timeout_s: int = 30
     )
 
 
+@pytest.mark.flaky_external
 def test_failed_job_error_visible_in_ui(
     authenticated_page,
     target_env,

tests/live/ui/test_job_polling.py

@@ -18,6 +18,7 @@
 pytestmark = pytest.mark.requires_token
 
 
+@pytest.mark.flaky_external
 def test_my_models_page_renders(authenticated_page, target_env) -> None:
     """U07: /my-models loads with auth and shows either models or an empty state."""
     errors = collect_console_errors(authenticated_page)

tests/unit/test_error_translation.py

@@ -184,7 +184,13 @@ def call(self, method, params):
                 raise RuntimeError("HTTPError: 504 Gateway Timeout")
 
         monkeypatch.setattr(genome_annotator, "RPCClient", AlwaysFlakyClient)
-        monkeypatch.setattr(genome_annotator, "_BACKOFF_SECONDS", (0, 0))
+        # Backoff tuple must have _MAX_RETRIES - 1 entries or the retry loop
+        # indexes past the end on the later attempts.
+        monkeypatch.setattr(
+            genome_annotator,
+            "_BACKOFF_SECONDS",
+            (0,) * (genome_annotator._MAX_RETRIES - 1),
+        )
 
         with pytest.raises(RuntimeError, match="504"):
             genome_annotator.annotate_fasta(">p1\nMKKLVAVLIVSLAVAL")