Commit 5fef41b
authored
fix: preserve log severity during trajectory redaction (#919)
#### Overview
Preserve valid `nemo_relay.log.severity` metadata during trajectory-context redaction so sanitized semantic logs remain exportable.
- [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license.
- [x] I searched existing issues and open pull requests, and this does not duplicate existing work.
#### Details
- Preserve supported log-severity values in canonical form without changing the existing policy for other mark metadata.
- Keep unsupported severity values subject to the configured custom-mark policy; `redact_all_leaves` redacts them.
- Add regression coverage for valid and invalid severity values and downstream subscriber delivery.
- Document the trajectory-context preset behavior.
Validation:
- PII-redaction crate tests: 147 passed
- Focused subscriber/exporter regression passed
- Workspace Clippy passed
- Documentation build passed
- Formatting and diff checks passed
#### Where should the reviewer start?
Start with `crates/pii-redaction/src/trajectory.rs`, especially the severity extraction and restoration around trajectory sanitization. The corresponding regression coverage is in `crates/pii-redaction/tests/unit/component_tests.rs`.
#### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
- Relates to #916
## Summary by CodeRabbit
- **Bug Fixes**
- Preserved valid log severity metadata during trajectory sanitization, including after payload, metadata, or category redaction.
- Normalized supported severity values to a canonical form.
- Continued redacting invalid or unsupported severity values and other sensitive custom-mark data.
- **Documentation**
- Clarified severity metadata handling in trajectory export and typed metric mark configuration documentation.
Authors:
- Maryam Najafian (https://github.com/mnajafian-nv)
Approvers:
- Will Killian (https://github.com/willkill07)
URL: #9191 parent d953a11 commit 5fef41b
4 files changed
Lines changed: 98 additions & 7 deletions
File tree
- crates/pii-redaction
- src
- tests/unit
- docs/configure-plugins/pii-redaction
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | | - | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
154 | 158 | | |
155 | 159 | | |
156 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
130 | 131 | | |
131 | 132 | | |
132 | 133 | | |
| 134 | + | |
133 | 135 | | |
134 | 136 | | |
135 | 137 | | |
| |||
140 | 142 | | |
141 | 143 | | |
142 | 144 | | |
143 | | - | |
| 145 | + | |
144 | 146 | | |
145 | 147 | | |
146 | 148 | | |
| |||
162 | 164 | | |
163 | 165 | | |
164 | 166 | | |
165 | | - | |
| 167 | + | |
166 | 168 | | |
167 | 169 | | |
168 | 170 | | |
| |||
180 | 182 | | |
181 | 183 | | |
182 | 184 | | |
183 | | - | |
| 185 | + | |
184 | 186 | | |
185 | 187 | | |
186 | 188 | | |
| |||
202 | 204 | | |
203 | 205 | | |
204 | 206 | | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
205 | 231 | | |
206 | 232 | | |
207 | 233 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
| 10 | + | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
1135 | 1135 | | |
1136 | 1136 | | |
1137 | 1137 | | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
| 1179 | + | |
| 1180 | + | |
| 1181 | + | |
| 1182 | + | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
1138 | 1186 | | |
1139 | 1187 | | |
1140 | 1188 | | |
| |||
2708 | 2756 | | |
2709 | 2757 | | |
2710 | 2758 | | |
| 2759 | + | |
2711 | 2760 | | |
2712 | 2761 | | |
2713 | 2762 | | |
| |||
2786 | 2835 | | |
2787 | 2836 | | |
2788 | 2837 | | |
| 2838 | + | |
| 2839 | + | |
| 2840 | + | |
| 2841 | + | |
| 2842 | + | |
| 2843 | + | |
| 2844 | + | |
2789 | 2845 | | |
2790 | 2846 | | |
2791 | 2847 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
267 | 267 | | |
268 | 268 | | |
269 | 269 | | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
270 | 275 | | |
271 | 276 | | |
272 | 277 | | |
| |||
0 commit comments