Commit 714dd2b
fix(core): report output_dim, not min_output_dim, when it is too small
``_resolve_output_bounds`` reported every floor violation against
``min_output_dim``, but ``lo`` is set to ``output_dim`` on the non-adaptive
branch. So setting ``output_dim=0`` blamed a parameter the caller had not
touched -- and one that is ignored entirely when ``adaptive`` is False:
Preprocessor(numerical_method="ple", output_dim=0)
-> min_output_dim must be >= 1, got 0.
Fix: raise min_output_dim to at least the family minimum.
Following that advice would not have helped. Families that pre-validate
``output_dim`` themselves (cubicspline, bspline) already reported it correctly,
so the two halves of the package disagreed.
Name the parameter that produced the value.
ple output_dim=0 -> output_dim must be >= 1, got 0.
cubicspline output_dim=0 -> output_dim must be >= 3 for the cubic spline basis, got 0
adaptive, min_output_dim=0 -> min_output_dim must be >= 1, got 0.
Closes #38
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent 51c3043 commit 714dd2b
2 files changed
Lines changed: 42 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
91 | 96 | | |
92 | | - | |
93 | | - | |
| 97 | + | |
| 98 | + | |
94 | 99 | | |
95 | 100 | | |
96 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
249 | 249 | | |
250 | 250 | | |
251 | 251 | | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
0 commit comments