Skip to content

Commit ae463a2

Browse files
committed
bin/compare_fresh_vs_update: reference cat_tools#67 and fix a stale job name
cat_tools#67 proposes generalizing this script's object-discovery-and- diff technique into a real cat_tools feature; note it as a natural follow-up. Also fix test/README.md's mention of the now-removed extension-update-test job (folded into test earlier in this stack).
1 parent d419a05 commit ae463a2

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

bin/compare_fresh_vs_update

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,15 @@
1616
# already updated to `EXECUTE FUNCTION`). Unlike that PR, this is committed,
1717
# reusable tooling rather than a one-off manual diff.
1818
#
19+
# Postgres-Extensions/cat_tools#67 proposes generalizing this exact
20+
# capability - "list every object an extension owns, with each object's
21+
# actual definition" - into a real, user-facing cat_tools feature, not
22+
# test-only plumbing tied to one extension's update path. If that lands,
23+
# this script's object-discovery-and-rendering logic (extension_members()
24+
# below, and the per-kind comparisons) is a natural candidate to
25+
# reimplement on top of it rather than staying a bespoke,
26+
# count_nulls-specific copy.
27+
#
1928
# What's compared, per object the extension owns (discovered live via
2029
# pg_depend - see extension_members(), not a hardcoded object list, so a
2130
# newly added function is automatically covered without editing this

test/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ then invoke via `runtests()`.
2525
strictness, and behavior across `anyarray`/`json`/`jsonb` and both
2626
trigger functions.
2727
- `../bin/compare_fresh_vs_update` — not part of the pgTAP suite itself: a
28-
standalone script the `extension-update-test` CI job runs after
28+
standalone script the `test` CI job's update leg runs after
2929
`TEST_LOAD_SOURCE=update`, which installs fresh and 0.9.6-then-updated
3030
copies of the extension in their own scratch databases and diffs
3131
`pg_get_functiondef`/comments/ACLs for every object the extension owns.

0 commit comments

Comments
 (0)