Skip to content

Commit 9d2fb69

Browse files
committed
Convert multi-line SQL comment to /* */ style
The ORDER BY rationale added for the pg_upgrade row-ordering fix used consecutive -- lines for one continuous remark; convert it to a /* */ block per the repo's comment convention (see the sibling foundation fix in advanced-testing/foundation).
1 parent 7526d05 commit 9d2fb69

1 file changed

Lines changed: 9 additions & 7 deletions

File tree

test/helpers/create.sql

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,15 @@ SELECT is(
9999
SELECT skip('role-restore check only applies when this session ran CREATE EXTENSION itself (test_load_mode=fresh)', 1);
100100
\endif
101101

102-
-- ORDER BY is load-bearing, not cosmetic: with no ordering this scans
103-
-- pg_proc in physical order, which happens to match creation order on a
104-
-- fresh CREATE EXTENSION but is NOT preserved by pg_upgrade (its
105-
-- dump/restore reconstructs pg_proc in a different, e.g. name-sorted,
106-
-- order) -- discovered because the pg_upgrade CI leg's "existing" run
107-
-- produced a row-reordered (but otherwise identical) diff against this
108-
-- same query's fresh-install expected output.
102+
/*
103+
* ORDER BY is load-bearing, not cosmetic: with no ordering this scans
104+
* pg_proc in physical order, which happens to match creation order on a
105+
* fresh CREATE EXTENSION but is NOT preserved by pg_upgrade (its
106+
* dump/restore reconstructs pg_proc in a different, e.g. name-sorted,
107+
* order) -- discovered because the pg_upgrade CI leg's "existing" run
108+
* produced a row-reordered (but otherwise identical) diff against this
109+
* same query's fresh-install expected output.
110+
*/
109111
SELECT cmp_ok(
110112
proconfig
111113
, '@>'

0 commit comments

Comments
 (0)