Skip to content

GPU optimization for maxabs - #481

Merged
kshyatt merged 6 commits into
mainfrom
ksh/gpumaxabs
Nov 6, 2026
Merged

kshyatt merged 6 commits into
mainfrom
ksh/gpumaxabs

Conversation

@kshyatt

@kshyatt kshyatt commented Oct 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@kshyatt

kshyatt commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

OK, so _maxabs is mostly used here in sdiag_pow. This is worth doing because sdiag_pow is called pretty frequently and doing things this way avoids a copy of a scalar back and forth between CPU memory and the GPU, when it's not needed.

@kshyatt
kshyatt requested a review from leburgel November 3, 2026 09:57

@leburgel leburgel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one, sorry. Looks good up to the one comment.

Comment thread src/utility/util.jl Resolved
@kshyatt
kshyatt marked this pull request as ready for review November 6, 2026 13:20
@kshyatt
kshyatt merged commit 6f2cb9e into main Nov 6, 2026
48 of 49 checks passed
@kshyatt
kshyatt deleted the ksh/gpumaxabs branch November 6, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants