Repository navigation
Allow cheaping out on convergence checks - #485
Merged
Merged
Conversation
leburgel
approved these changes
Nov 5, 2026
Member
Author
|
All the GPU fails here are going to be addressed by the next TK version so I will merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is to save some work while the CTMRG environments are converging. We check whether the
maxof the singular value distances is above the tolerance, so if the corners are already above, we don't need to calculate the edge SVDs to know things are not converged. This saves us a bunch of SVD calls at the cost of somewhat less accurate error reporting, so it's kind of a proposal rather than a "we should definitely do this". For C4v CTMRG this is especially helpful on the GPU because we can do onlyeighs for a while, avoiding the expensive and slowsvds.