Skip to content

Normalize with normalize function so we can override - #487

Merged
kshyatt merged 1 commit into
mainfrom
ksh/normalize
Nov 6, 2026
Merged

kshyatt merged 1 commit into
mainfrom
ksh/normalize

Conversation

@kshyatt

@kshyatt kshyatt commented Nov 5, 2026

Copy link
Copy Markdown
Member

This should allow us to use some GPU specific paths which will avoid blocking the device

@kshyatt
kshyatt requested review from lkdvos and pbrehmer November 5, 2026 12:44
@lkdvos

lkdvos commented Nov 5, 2026

Copy link
Copy Markdown
Member

Definitely looks good to me, although I feel like there must be way more places where this is used. As a side note, I think all of these could be normalize! but AD doesn't like mutating, so should we introduce normalize!! in TensorKit for that, or simply wait for Enzyme to land so we can support that automatically?

@kshyatt

kshyatt commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

I feel like there must be way more places where this is used

I grepped every instance of norm( and this is what I found 🤷

@kshyatt

kshyatt commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

simply wait for Enzyme to land so we can support that automatically

This makes sense to me

@kshyatt

kshyatt commented Nov 6, 2026

Copy link
Copy Markdown
Member Author

CUDA failures here are the known ones from the stuff we need from TK.

@kshyatt
kshyatt merged commit 54ad703 into main Nov 6, 2026
31 of 32 checks passed
@kshyatt
kshyatt deleted the ksh/normalize branch November 6, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants