Remove dead code flagged by Periphery

Prune unused symbols the scan flagged and enforce `periphery scan --strict` in CI.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: RISCfuture

.github/workflows/periphery.yml

@@ -17,4 +17,4 @@ jobs:
       - name: Install Periphery
         run: brew install periphery
       - name: Run Periphery
-        run: periphery scan
+        run: periphery scan --strict

.periphery.yml

@@ -1 +1,18 @@
 retain_public: true
+
+# The CIFPDataLinkable / ProcedureLinkable / AirwayLinkable protocols are a live
+# linking-architecture design: CIFPData calls injectLegResolvers/injectFixResolvers
+# and sets `data` on conformers. Periphery flags them as "redundant" only because they
+# are never used as existential types, so they carry targeted `// periphery:ignore`
+# comments. In Periphery 3.7.4 such an ignore (which correctly suppresses the
+# redundant-protocol finding) is itself reported as a superfluous ignore comment under
+# --strict, so superfluous-ignore reporting is disabled to retain the architecture.
+superfluous_ignore_comments: false
+
+# ASCII.swift is a deliberately complete byte-constant table (full A-Z, 0-9,
+# punctuation) plus isUpperAlpha/isAlphanumeric helpers. Its currently unused
+# members are intentional, so retain the whole file. (Periphery 3.7.4 does not
+# propagate `// periphery:ignore:all` to an enum's static members, so file-level
+# retention is used instead of a comment directive.)
+retain_files:
+  - "**/Parser/ASCII.swift"

Sources/SwiftCIFP/CIFPDataLinkable.swift

@@ -9,6 +9,8 @@ import Foundation
 /// - Note: Conforming types should declare the `data` property as `weak`
 ///   to avoid retain cycles with the parent `CIFPData` actor.
 protocol CIFPDataLinkable {
+  // periphery:ignore - Live linking-architecture requirement; flagged only because the
+  // protocol is never used as an existential type. Conforming models set this property.
   /// Reference to the parent CIFPData container.
   ///
   /// This property is set by `CIFPData` when establishing model links.
@@ -42,6 +44,9 @@ typealias NavaidResolver =
     _ sectionCode: String?
   ) async -> Navaid?
 
+// periphery:ignore - Live linking-architecture protocol; injectLegResolvers is called in
+// CIFPData.swift. Periphery flags it "redundant" only because it is never used as an
+// existential type. Do not collapse into CIFPDataLinkable.
 /// Protocol for procedure models that contain legs requiring closure injection.
 ///
 /// Procedures (SID, STAR, Approach) contain nested `ProcedureLeg` structures
@@ -62,6 +67,9 @@ protocol ProcedureLinkable: CIFPDataLinkable {
   )
 }
 
+// periphery:ignore - Live linking-architecture protocol; injectFixResolvers is called in
+// CIFPData.swift. Periphery flags it "redundant" only because it is never used as an
+// existential type. Do not collapse into CIFPDataLinkable.
 /// Protocol for airway models that contain fixes requiring closure injection.
 ///
 /// Airways contain nested `AirwayFix` structures that need to resolve

Sources/SwiftCIFP/Models/Heliport/HeliportApproach.swift

@@ -8,12 +8,6 @@ public struct HeliportApproach: Sendable, Codable, ProcedureLinkable {
   /// Reference to the parent CIFPData container for model linking.
   public weak var data: CIFPData?
 
-  /// Closure for resolving fix identifiers (internal use).
-  var findFix: FixResolver?
-
-  /// Closure for resolving navaid identifiers (internal use).
-  var findNavaid: NavaidResolver?
-
   /// Parent heliport ICAO identifier.
   let parentId: String
 
@@ -59,7 +53,7 @@ public struct HeliportApproach: Sendable, Codable, ProcedureLinkable {
   private enum CodingKeys: String, CodingKey {
     case parentId, icaoRegion, identifier, approachType
     case transitionId, legs, missedApproachLegs
-    // Note: 'data', 'findFix', 'findNavaid' are excluded
+    // Note: 'data' is excluded
   }
 }
 
@@ -91,9 +85,6 @@ extension HeliportApproach {
     findFix: @escaping FixResolver,
     findNavaid: @escaping NavaidResolver
   ) {
-    self.findFix = findFix
-    self.findNavaid = findNavaid
-
     // Inject into approach legs
     for i in legs.indices {
       legs[i].findFix = findFix

Sources/SwiftCIFP/Models/Procedures/Approach.swift

@@ -11,12 +11,6 @@ public struct Approach: Sendable, Codable, ProcedureLinkable {
   /// Reference to the parent CIFPData container for model linking.
   public weak var data: CIFPData?
 
-  /// Closure for resolving fix identifiers (internal use).
-  var findFix: FixResolver?
-
-  /// Closure for resolving navaid identifiers (internal use).
-  var findNavaid: NavaidResolver?
-
   /// Parent airport ICAO identifier.
   let airportId: String
 
@@ -131,7 +125,7 @@ public struct Approach: Sendable, Codable, ProcedureLinkable {
     case routeType, transitionId, runwayId
     case multipleIndicator, legs, missedApproachLegs
     case sbasServiceLevel, requiredNavPerformance, lateralNavCapability
-    // Note: 'data', 'findFix', 'findNavaid' are excluded
+    // Note: 'data' is excluded
   }
 }
 
@@ -175,9 +169,6 @@ extension Approach {
     findFix: @escaping FixResolver,
     findNavaid: @escaping NavaidResolver
   ) {
-    self.findFix = findFix
-    self.findNavaid = findNavaid
-
     // Inject into approach legs
     for i in legs.indices {
       legs[i].findFix = findFix

Sources/SwiftCIFP/Models/Procedures/SID.swift

@@ -11,12 +11,6 @@ public struct SID: Sendable, Codable, ProcedureLinkable {
   /// Reference to the parent CIFPData container for model linking.
   public weak var data: CIFPData?
 
-  /// Closure for resolving fix identifiers (internal use).
-  var findFix: FixResolver?
-
-  /// Closure for resolving navaid identifiers (internal use).
-  var findNavaid: NavaidResolver?
-
   /// Parent airport ICAO identifier.
   let airportId: String
 
@@ -72,7 +66,7 @@ public struct SID: Sendable, Codable, ProcedureLinkable {
   private enum CodingKeys: String, CodingKey {
     case airportId, icaoRegion, identifier, routeType
     case transitionId, runwayNames = "runways", legs
-    // Note: 'data', 'findFix', 'findNavaid' are excluded
+    // Note: 'data' is excluded
   }
 }
 
@@ -116,9 +110,6 @@ extension SID {
     findFix: @escaping FixResolver,
     findNavaid: @escaping NavaidResolver
   ) {
-    self.findFix = findFix
-    self.findNavaid = findNavaid
-
     // Inject into all legs
     for i in legs.indices {
       legs[i].findFix = findFix

Sources/SwiftCIFP/Models/Procedures/STAR.swift

@@ -11,12 +11,6 @@ public struct STAR: Sendable, Codable, ProcedureLinkable {
   /// Reference to the parent CIFPData container for model linking.
   public weak var data: CIFPData?
 
-  /// Closure for resolving fix identifiers (internal use).
-  var findFix: FixResolver?
-
-  /// Closure for resolving navaid identifiers (internal use).
-  var findNavaid: NavaidResolver?
-
   /// Parent airport ICAO identifier.
   let airportId: String
 
@@ -77,7 +71,7 @@ public struct STAR: Sendable, Codable, ProcedureLinkable {
   private enum CodingKeys: String, CodingKey {
     case airportId, icaoRegion, identifier, routeType
     case transitionId, runwayNames = "runways", legs
-    // Note: 'data', 'findFix', 'findNavaid' are excluded
+    // Note: 'data' is excluded
   }
 }
 
@@ -121,9 +115,6 @@ extension STAR {
     findFix: @escaping FixResolver,
     findNavaid: @escaping NavaidResolver
   ) {
-    self.findFix = findFix
-    self.findNavaid = findNavaid
-
     // Inject into all legs
     for i in legs.indices {
       legs[i].findFix = findFix

Sources/SwiftCIFP/Models/Standalone/Airway.swift

@@ -195,9 +195,6 @@ public struct Airway: Sendable, Codable, AirwayLinkable {
   /// Reference to the parent CIFPData container for model linking.
   public weak var data: CIFPData?
 
-  /// Closure for resolving fix identifiers (internal use).
-  var findFix: FixResolver?
-
   /// The airway identifier (e.g., "V1", "J60", "Q105").
   public let identifier: String
 
@@ -237,7 +234,7 @@ public struct Airway: Sendable, Codable, AirwayLinkable {
 
   private enum CodingKeys: String, CodingKey {
     case identifier, routeType, level, fixes
-    // Note: 'data', 'findFix' are excluded
+    // Note: 'data' is excluded
   }
 }
 
@@ -246,8 +243,6 @@ public struct Airway: Sendable, Codable, AirwayLinkable {
 extension Airway {
   /// Injects fix resolver closures into the airway's fixes.
   mutating func injectFixResolvers(findFix: @escaping FixResolver) {
-    self.findFix = findFix
-
     // Inject into all fixes
     for i in fixes.indices {
       fixes[i].findFix = findFix

Sources/SwiftCIFP/Parser/ASCII.swift

@@ -1,6 +1,14 @@
 import Foundation
 
 /// ASCII byte constants for efficient byte-level parsing.
+///
+/// This is a deliberately complete byte-constant table (full A-Z, 0-9, and
+/// punctuation) plus the `isUpperAlpha`/`isAlphanumeric` helpers. The currently
+/// unused members are retained intentionally so the table stays whole and
+/// callers can reference any byte without piecemeal additions. Whole-file
+/// retention is configured in `.periphery.yml` (`retain_files`) rather than a
+/// comment directive, because Periphery 3.7.4 does not propagate
+/// `// periphery:ignore:all` to an enum's static members.
 @usableFromInline
 enum ASCII {
   @usableFromInline static let LF: UInt8 = 0x0A  // '\n'

Sources/SwiftCIFP/Parser/ByteParsing.swift

@@ -99,14 +99,6 @@ extension RandomAccessCollection where Element == UInt8, Index == Int {
     return negative ? -value : value
   }
 
-  /// Get a single byte at offset, or nil if out of bounds.
-  @inlinable
-  func byte(at offset: Int) -> UInt8? {
-    let idx = startIndex + offset
-    guard idx < endIndex else { return nil }
-    return self[idx]
-  }
-
   /// Get a subsequence using a relative range from startIndex.
   @inlinable
   func slice(_ range: Range<Int>) -> SubSequence {
@@ -115,20 +107,6 @@ extension RandomAccessCollection where Element == UInt8, Index == Int {
     return self[lower..<Swift.min(upper, endIndex)]
   }
 
-  /// Check if bytes match a string (trimming trailing whitespace).
-  @inlinable
-  func matches(_ string: String) -> Bool {
-    let target = Array(string.utf8)
-    var selfTrimmed = self[...]
-
-    while let last = selfTrimmed.last, last == ASCII.space {
-      selfTrimmed = selfTrimmed.dropLast()
-    }
-
-    guard selfTrimmed.count == target.count else { return false }
-    return zip(selfTrimmed, target).allSatisfy { $0 == $1 }
-  }
-
   /// Convert to trimmed String (only when actually needed).
   @inlinable
   func toString() -> String {