RG-T117 PR#123 fixes

Author: ucswift

package.json

@@ -127,6 +127,7 @@
     "expo-auth-session": "~7.0.11",
     "expo-av": "~16.0.8",
     "expo-build-properties": "~1.0.10",
+    "expo-clipboard": "~8.0.8",
     "expo-constants": "~18.0.13",
     "expo-crypto": "~15.0.9",
     "expo-dev-client": "~6.0.21",

src/app/chat/[channelId].tsx

@@ -56,18 +56,35 @@ export default function ChannelConversationScreen() {
   const [editText, setEditText] = useState('');
   const [imageUri, setImageUri] = useState<string | null>(null);
   const [presenceIds, setPresenceIds] = useState<Set<string>>(new Set());
+  const [resolveAttempted, setResolveAttempted] = useState(false);
   const unsubscribeRef = useRef<(() => void) | null>(null);
 
   const isDm = channel?.ChannelType === ChatChannelType.DirectMessage;
   const showSender = !isDm;
+  const isChatbot = channel?.ChannelType === ChatChannelType.Chatbot;
+  // Deep links (push notifications, cold starts) can arrive before the channel
+  // list loads; the channel type is unknown until then. Treat a completed fetch
+  // with no match as resolved so unknown channels keep the generic screen.
+  const isResolved = !!channel || resolveAttempted;
 
   // Newest-first for the inverted list.
   const inverted = useMemo(() => (messages ? messages.slice().reverse() : []), [messages]);
 
-  // Mount: activate channel, join hub, load history and members.
+  // Resolve the channel identity for deep links before mounting the generic view.
+  useEffect(() => {
+    if (channel || resolveAttempted || !isChatEnabled) return;
+    void useChatStore
+      .getState()
+      .fetchChannels()
+      .finally(() => setResolveAttempted(true));
+  }, [channel, resolveAttempted, isChatEnabled]);
+
+  // Mount: activate channel, join hub, load history and members. Assistant
+  // conversations are handled by the dedicated chatbot screen — never join or
+  // load them here, and wait for unresolved deep links to identify first.
   useFocusEffect(
     useCallback(() => {
-      if (!channelId || !isChatEnabled) return;
+      if (!channelId || !isChatEnabled || !isResolved || isChatbot) return;
       const store = useChatStore.getState();
       store.setActiveChannel(channelId);
       void store.joinChannel(channelId);
@@ -76,7 +93,7 @@ export default function ChannelConversationScreen() {
       return () => {
         useChatStore.getState().setActiveChannel(null);
       };
-    }, [channelId, isChatEnabled])
+    }, [channelId, isChatEnabled, isResolved, isChatbot])
   );
 
   // Fetch presence for the channel members (for the header online dot).
@@ -96,10 +113,10 @@ export default function ChannelConversationScreen() {
 
   // Mark read whenever the newest message changes while viewing.
   useEffect(() => {
-    if (channelId && inverted.length > 0) {
+    if (channelId && isResolved && !isChatbot && inverted.length > 0) {
       void useChatStore.getState().markChannelRead(channelId);
     }
-  }, [channelId, inverted.length]);
+  }, [channelId, inverted.length, isResolved, isChatbot]);
 
   const otherOnline = useMemo(() => {
     if (!isDm) return false;
@@ -254,9 +271,20 @@ export default function ChannelConversationScreen() {
     return <Redirect href={'/home' as Href} />;
   }
 
+  // Deep link to a channel that isn't loaded yet: wait for the channel list so
+  // assistant conversations never mount the full-featured view.
+  if (!isResolved) {
+    return (
+      <Box className="size-full flex-1 items-center justify-center bg-background-0">
+        <Stack.Screen options={{ title, headerShown: true, headerBackTitle: '' }} />
+        <Spinner />
+      </Box>
+    );
+  }
+
   // Assistant conversations always use the dedicated restricted screen (text only,
   // no reactions/threads/deletes) — catch deep links and stale routes here.
-  if (channel?.ChannelType === ChatChannelType.Chatbot) {
+  if (isChatbot) {
     return <Redirect href={'/chatbot' as Href} />;
   }
 

src/components/chat/__tests__/chat-utils.test.ts

@@ -1,8 +1,11 @@
+import * as Clipboard from 'expo-clipboard';
 import { type TFunction } from 'i18next';
 
 import { ChatChannelType, type ChatChannelResultData } from '@/models/v4/chat';
 
-import { getChannelDisplayName, getImageMimeType, hasLink, linkifySegments } from '../chat-utils';
+import { copyToClipboard, getChannelDisplayName, getImageMimeType, hasLink, linkifySegments } from '../chat-utils';
+
+jest.mock('expo-clipboard', () => ({ setStringAsync: jest.fn() }));
 
 const mockT = ((key: string) => key) as TFunction;
 
@@ -74,6 +77,56 @@ describe('chat-utils', () => {
     });
   });
 
+  describe('copyToClipboard', () => {
+    const globalWithNavigator = globalThis as unknown as { navigator?: { clipboard?: { writeText?: (value: string) => Promise<void> } } };
+    let originalNavigator: unknown;
+
+    beforeEach(() => {
+      originalNavigator = globalWithNavigator.navigator;
+      jest.mocked(Clipboard.setStringAsync).mockReset();
+    });
+
+    afterEach(() => {
+      if (originalNavigator === undefined) {
+        delete globalWithNavigator.navigator;
+      } else {
+        globalWithNavigator.navigator = originalNavigator as typeof globalWithNavigator.navigator;
+      }
+    });
+
+    it('uses the web clipboard API when available', async () => {
+      const writeText = jest.fn().mockResolvedValue(undefined);
+      globalWithNavigator.navigator = { clipboard: { writeText } };
+
+      await expect(copyToClipboard('hello')).resolves.toBe(true);
+      expect(writeText).toHaveBeenCalledWith('hello');
+      expect(Clipboard.setStringAsync).not.toHaveBeenCalled();
+    });
+
+    it('falls back to the native module when the web API is unavailable', async () => {
+      delete globalWithNavigator.navigator;
+      jest.mocked(Clipboard.setStringAsync).mockResolvedValue(true);
+
+      await expect(copyToClipboard('hello')).resolves.toBe(true);
+      expect(Clipboard.setStringAsync).toHaveBeenCalledWith('hello');
+    });
+
+    it('falls back to the native module when the web API write fails', async () => {
+      globalWithNavigator.navigator = { clipboard: { writeText: jest.fn().mockRejectedValue(new Error('denied')) } };
+      jest.mocked(Clipboard.setStringAsync).mockResolvedValue(true);
+
+      await expect(copyToClipboard('hello')).resolves.toBe(true);
+      expect(Clipboard.setStringAsync).toHaveBeenCalledWith('hello');
+    });
+
+    it('returns false when the native write fails', async () => {
+      delete globalWithNavigator.navigator;
+      jest.mocked(Clipboard.setStringAsync).mockRejectedValue(new Error('unavailable'));
+
+      await expect(copyToClipboard('hello')).resolves.toBe(false);
+    });
+  });
+
   describe('linkifySegments', () => {
     it('splits multiple links and surrounding text', () => {
       expect(linkifySegments('go to https://a.com or http://b.com now')).toEqual([

src/components/chat/chat-utils.ts

@@ -1,3 +1,4 @@
+import * as Clipboard from 'expo-clipboard';
 import { type TFunction } from 'i18next';
 
 import { getAvatarUrl } from '@/lib/utils';
@@ -105,9 +106,9 @@ export function hasLink(body?: string | null): boolean {
 }
 
 /**
- * Copies text to the clipboard. Works on web/Electron via the async Clipboard
- * API; native returns false (no clipboard native module is installed) so callers
- * can surface an appropriate message.
+ * Copies text to the clipboard. Uses the async Clipboard API on web/Electron
+ * and expo-clipboard on native; returns false only when both are unavailable
+ * or the write fails, so callers can surface an appropriate message.
  */
 export async function copyToClipboard(text: string): Promise<boolean> {
   try {
@@ -117,9 +118,13 @@ export async function copyToClipboard(text: string): Promise<boolean> {
       return true;
     }
   } catch {
-    // ignore and fall through
+    // ignore and fall through to the native module
+  }
+  try {
+    return await Clipboard.setStringAsync(text);
+  } catch {
+    return false;
   }
-  return false;
 }
 
 const IMAGE_MIME_BY_EXTENSION: Record<string, string> = {

yarn.lock

@@ -8047,6 +8047,11 @@ expo-build-properties@~1.0.10:
     ajv "^8.11.0"
     semver "^7.6.0"
 
+expo-clipboard@~8.0.8:
+  version "8.0.8"
+  resolved "https://registry.yarnpkg.com/expo-clipboard/-/expo-clipboard-8.0.8.tgz#5e52054a4bbaebef090ec6fe5eaa200072ff94f7"
+  integrity sha512-VKoBkHIpZZDJTB0jRO4/PZskHdMNOEz3P/41tmM6fDuODMpqhvyWK053X0ebspkxiawJX9lX33JXHBCvVsTTOA==
+
 expo-constants@~18.0.13:
   version "18.0.13"
   resolved "https://registry.yarnpkg.com/expo-constants/-/expo-constants-18.0.13.tgz#0117f1f3d43be7b645192c0f4f431fb4efc4803d"