Skip to content

Commit 5f2b1b5

Browse files
committed
Matching the test invokes to rest of the project tests
1 parent eff55fe commit 5f2b1b5

5 files changed

Lines changed: 19 additions & 16 deletions

File tree

Makefile.in

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -389,15 +389,15 @@ check-progs: all $(CHECK_PROGS) $(CHECK_SYMLINKS)
389389

390390
.PHONY: check
391391
check: all $(CHECK_PROGS) $(CHECK_SYMLINKS)
392-
$(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(CHECK_J)
392+
$(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(CHECK_J) @LTFS_RUNTESTS_ARGS@
393393

394394
.PHONY: check29
395395
check29: all $(CHECK_PROGS) $(CHECK_SYMLINKS)
396-
$(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(CHECK_J) --protocol=29
396+
$(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(CHECK_J) --protocol=29 @LTFS_RUNTESTS_ARGS@
397397

398398
.PHONY: check30
399399
check30: all $(CHECK_PROGS) $(CHECK_SYMLINKS)
400-
$(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(CHECK_J) --protocol=30
400+
$(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(CHECK_J) --protocol=30 @LTFS_RUNTESTS_ARGS@
401401

402402
# Whole-suite gcov coverage report (HTML, with branch + decision coverage).
403403
# Requires a build configured with --enable-coverage and the `gcovr` tool
@@ -412,7 +412,7 @@ coverage: all $(CHECK_PROGS) $(CHECK_SYMLINKS)
412412
*) echo "*** not a coverage build; reconfigure with --enable-coverage"; exit 1 ;; esac
413413
@command -v gcovr >/dev/null 2>&1 || { echo "*** gcovr not found (pip install gcovr)"; exit 1; }
414414
find . -name '*.gcda' -delete
415-
@rc=0; $(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(COVERAGE_J) $(COVERAGE_RUNFLAGS) || rc=$$?; \
415+
@rc=0; $(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(COVERAGE_J) $(COVERAGE_RUNFLAGS) @LTFS_RUNTESTS_ARGS@ || rc=$$?; \
416416
rm -rf $(COVERAGE_DIR) && mkdir -p $(COVERAGE_DIR); \
417417
gcovr --root $(srcdir) $(COVERAGE_EXCLUDE) --decisions --print-summary \
418418
--html-details -o $(COVERAGE_DIR)/index.html . || exit $$?; \
@@ -444,7 +444,7 @@ coverage-all: all $(CHECK_PROGS) $(CHECK_SYMLINKS)
444444
@rc=0; \
445445
for cfg in '' '--protocol=30' '--protocol=29' '--use-tcp'; do \
446446
echo "===== coverage-all: runtests.py $$cfg ====="; \
447-
$(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(COVERAGE_J) $$cfg || rc=$$?; \
447+
$(srcdir)/runtests.py --rsync-bin=`pwd`/rsync$(EXEEXT) -j $(COVERAGE_J) $$cfg @LTFS_RUNTESTS_ARGS@ || rc=$$?; \
448448
done; \
449449
rm -rf coverage-all && mkdir -p coverage-all; \
450450
gcovr --root $(srcdir) $(COVERAGE_EXCLUDE) --decisions --print-summary \
@@ -498,7 +498,7 @@ testsuite/exclude-lsh_test.py:
498498

499499
.PHONY: installcheck
500500
installcheck: $(CHECK_PROGS) $(CHECK_SYMLINKS)
501-
$(srcdir)/runtests.py --rsync-bin="$(bindir)/rsync$(EXEEXT)" --srcdir="$(srcdir)" --tooldir=`pwd` -j $(CHECK_J)
501+
$(srcdir)/runtests.py --rsync-bin="$(bindir)/rsync$(EXEEXT)" --srcdir="$(srcdir)" --tooldir=`pwd` -j $(CHECK_J) @LTFS_RUNTESTS_ARGS@
502502

503503
# TODO: Add 'dist' target; need to know which files will be included
504504

configure

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -629,6 +629,7 @@ ac_unique_file="byteorder.h"
629629
ac_config_libobj_dir=lib
630630
: ${enable_year2038:=no}
631631
ac_subst_vars='LTLIBOBJS
632+
LTFS_RUNTESTS_ARGS
632633
LTFS_CHECK_OBJS
633634
LTFS_CHECK_PROGS
634635
MAKE_MAN
@@ -12575,19 +12576,23 @@ if test x"$enable_ltfs" != x"no" && test x"$enable_xattr_support" != x"no"; then
1257512576
*cygwin*)
1257612577
LTFS_CHECK_PROGS=''
1257712578
LTFS_CHECK_OBJS=''
12579+
LTFS_RUNTESTS_ARGS='--exclude=ltfs-server-reject,ltfs-client-compat'
1257812580
;;
1257912581
*)
1258012582
LTFS_CHECK_PROGS='rsync_noltfs$(EXEEXT)'
1258112583
LTFS_CHECK_OBJS='options_noltfs.o'
12584+
LTFS_RUNTESTS_ARGS=''
1258212585
;;
1258312586
esac
1258412587
else
1258512588
LTFS_CHECK_PROGS=''
1258612589
LTFS_CHECK_OBJS=''
12590+
LTFS_RUNTESTS_ARGS='--exclude=ltfs-server-reject,ltfs-client-compat'
1258712591
fi
1258812592

1258912593

1259012594

12595+
1259112596
if test x"$enable_acl_support" = x"no" || test x"$enable_xattr_support" = x"no" || test x"$enable_iconv" = x"no"; then
1259212597
{ printf '%s\n' "$as_me:${as_lineno-$LINENO}: checking whether $CC supports -Wno-unused-parameter" >&5
1259312598
printf %s "checking whether $CC supports -Wno-unused-parameter... " >&6; }

configure.ac

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1490,18 +1490,22 @@ if test x"$enable_ltfs" != x"no" && test x"$enable_xattr_support" != x"no"; then
14901490
*cygwin*)
14911491
LTFS_CHECK_PROGS=''
14921492
LTFS_CHECK_OBJS=''
1493+
LTFS_RUNTESTS_ARGS='--exclude=ltfs-server-reject,ltfs-client-compat'
14931494
;;
14941495
*)
14951496
LTFS_CHECK_PROGS='rsync_noltfs$(EXEEXT)'
14961497
LTFS_CHECK_OBJS='options_noltfs.o'
1498+
LTFS_RUNTESTS_ARGS=''
14971499
;;
14981500
esac
14991501
else
15001502
LTFS_CHECK_PROGS=''
15011503
LTFS_CHECK_OBJS=''
1504+
LTFS_RUNTESTS_ARGS='--exclude=ltfs-server-reject,ltfs-client-compat'
15021505
fi
15031506
AC_SUBST(LTFS_CHECK_PROGS)
15041507
AC_SUBST(LTFS_CHECK_OBJS)
1508+
AC_SUBST(LTFS_RUNTESTS_ARGS)
15051509

15061510
if test x"$enable_acl_support" = x"no" || test x"$enable_xattr_support" = x"no" || test x"$enable_iconv" = x"no"; then
15071511
AC_MSG_CHECKING([whether $CC supports -Wno-unused-parameter])

testsuite/ltfs-client-compat_test.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,20 +11,17 @@
1111
# SUPPORT_XATTRS (which also suppresses SUPPORT_LTFS). It acts as the
1212
# client here; the daemon runs the normal LTFS-capable build.
1313

14-
import shutil
1514
import subprocess
1615

1716
from rsyncfns import (
1817
FROMDIR, TODIR, TOOLDIR,
1918
build_rsyncd_conf, checkit, makepath, rsync_argv,
20-
start_test_daemon, test_fail, test_skipped,
19+
start_test_daemon, test_fail,
2120
)
2221

2322
DAEMON_PORT = 12897
2423

25-
noltfs_bin = shutil.which('rsync_noltfs', path=str(TOOLDIR))
26-
if noltfs_bin is None:
27-
test_skipped(f"rsync_noltfs binary not found in TOOLDIR ({TOOLDIR})")
24+
noltfs_bin = str(TOOLDIR / 'rsync_noltfs')
2825

2926
# --- setup -------------------------------------------------------------------
3027

testsuite/ltfs-server-reject_test.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,17 @@
88
# local pipe (RSYNC_CONNECT_PROG) so no TCP socket or real LTFS volume is
99
# needed, and the test runs on all platforms regardless of xattr support.
1010

11-
import shutil
1211
import subprocess
1312

1413
from rsyncfns import (
1514
FROMDIR, TODIR, TOOLDIR,
1615
build_rsyncd_conf, makepath, rsync_argv,
17-
start_test_daemon, test_fail, test_skipped,
16+
start_test_daemon, test_fail,
1817
)
1918

2019
DAEMON_PORT = 12896
2120

22-
noltfs_bin = shutil.which('rsync_noltfs', path=str(TOOLDIR))
23-
if noltfs_bin is None:
24-
test_skipped(f"rsync_noltfs binary not found in TOOLDIR ({TOOLDIR})")
21+
noltfs_bin = str(TOOLDIR / 'rsync_noltfs')
2522

2623
makepath(FROMDIR, TODIR)
2724
(FROMDIR / 'probe.txt').write_text('hello from the ltfs-server-reject test\n')

0 commit comments

Comments
 (0)