Skip to content

Commit fca58e1

Browse files
committed
fix: Add alias_tokens parameter to _parse_join() for sqlglot 30.9.0 compatibility
- Add missing alias_tokens parameter to _parse_join() method signature - Pass alias_tokens to internal __parse_join() calls - Maintain backward compatibility with optional parameter - Fixes TypeError when using sqlglot 30.9.0 or later Resolves compatibility issue where SQLMesh's _parse_join() override was incompatible with sqlglot 30.9.0's updated method signature. Signed-off-by: Awanish Gupta <awanishgupta159@gmail.com>
1 parent b44fdf6 commit fca58e1

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

sqlmesh/core/dialect.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,16 +315,19 @@ def _parse_with(self: Parser, skip_with_token: bool = False) -> t.Optional[exp.E
315315

316316

317317
def _parse_join(
318-
self: Parser, skip_join_token: bool = False, parse_bracket: bool = False
318+
self: Parser,
319+
skip_join_token: bool = False,
320+
parse_bracket: bool = False,
321+
alias_tokens: t.Optional[t.Collection[TokenType]] = None,
319322
) -> t.Optional[exp.Expr]:
320323
index = self._index
321324
method, side, kind = self._parse_join_parts()
322325
macro = _parse_matching_macro(self, "JOIN")
323326
if not macro:
324327
self._retreat(index)
325-
return self.__parse_join(skip_join_token=skip_join_token, parse_bracket=parse_bracket) # type: ignore
328+
return self.__parse_join(skip_join_token=skip_join_token, parse_bracket=parse_bracket, alias_tokens=alias_tokens) # type: ignore
326329

327-
join = self.__parse_join(skip_join_token=True) # type: ignore
330+
join = self.__parse_join(skip_join_token=True, alias_tokens=alias_tokens) # type: ignore
328331
if method:
329332
join.set("method", method.text)
330333
if side:

0 commit comments

Comments
 (0)