Skip to content

Commit 6b3fbfa

Browse files
authored
Merge pull request #23 from rpartzsch/qt6-update
Qt6
2 parents c911a09 + 85332cb commit 6b3fbfa

8 files changed

Lines changed: 15 additions & 27 deletions

File tree

.github/workflows/main.yml

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -38,23 +38,10 @@ jobs:
3838
- name: Package installation
3939
run: pip install -e .
4040

41-
- name: Qt5 defaults
42-
shell: bash -l {0}
43-
run: |
44-
if [[ "$RUNNER_OS" == "Linux" ]];
45-
then
46-
echo "Qt5 default installation on $RUNNER_OS"
47-
sudo apt-get install qttools5-dev-tools
48-
fi
49-
50-
if [[ "$RUNNER_OS" == "Windows" ]];
51-
then
52-
echo "Qt5 default installation on $RUNNER_OS"
53-
choco install qt5-default
54-
fi
55-
5641
- name: Headless display setup
57-
uses: pyvista/setup-headless-display-action@v3
42+
uses: pyvista/setup-headless-display-action@v4
43+
with:
44+
qt: true
5845

5946
- name: Testing on branch -> ${{github.head_ref || github.ref_name}}
6047
run: pytest online_monitor
@@ -77,10 +64,11 @@ jobs:
7764
run: |
7865
pip install blosc
7966
pip install -e .
80-
sudo apt-get install qttools5-dev-tools
8167
8268
- name: Headless display setup
83-
uses: pyvista/setup-headless-display-action@v3
69+
uses: pyvista/setup-headless-display-action@v4
70+
with:
71+
qt: true
8472

8573
- name: Coverage report and upload
8674
env:

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ This makes all converter / receiver / etc. instances within `path/to/plugin/fold
7373
# Custom receiver
7474
Have a look at [the examples](online_monitor/examples/receiver).
7575
When building your custom receiver, use `pyqtgraph` only for plotting-related tasks e.g. `pg.ImageItem` etc.
76-
Avoid using `pyqtgraph` for building generic widgets (especially the deprecated `QtGui` submodule), instead use `pyqt5` directly:
76+
Avoid using `pyqtgraph` for building generic widgets (especially the deprecated `QtGui` submodule), instead use `pyqt6` directly:
7777
```
78-
from PyQt5 import QtWidgets, QtCore
78+
from PyQt6 import QtWidgets, QtCore
7979
8080
my_custom_label = QtWidgets.QLabel("My label")
8181
my_custom_double_spinbox = QtWidgets.QDoubleSpinBox()

online_monitor/OnlineMonitor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import sys
22
import logging
33

4-
from PyQt5 import QtWidgets, QtCore
4+
from PyQt6 import QtWidgets, QtCore
55
import pyqtgraph as pg
66
from pyqtgraph.dockarea import DockArea, Dock
77

online_monitor/examples/receiver/bidirectional_receiver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import pyqtgraph as pg
66
from pyqtgraph.dockarea import DockArea, Dock
77

8-
from PyQt5 import QtWidgets
8+
from PyQt6 import QtWidgets
99

1010
from online_monitor.utils import utils
1111

online_monitor/receiver/receiver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from PyQt5 import QtCore
1+
from PyQt6 import QtCore
22
import zmq
33
import logging
44
from threading import Event

online_monitor/start_online_monitor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import psutil
55
import subprocess
66
import logging
7-
from PyQt5 import QtWidgets
7+
from PyQt6 import QtWidgets
88

99

1010
from online_monitor.utils import settings
@@ -46,7 +46,7 @@ def __init__(self):
4646

4747
# Helper function to run code after OnlineMonitor Application exit
4848
def appExec():
49-
app.exec_()
49+
app.exec()
5050
# Stop other processes
5151
try:
5252
kill(producer_sim_process)

online_monitor/testing/test_online_monitor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import time
99
import os
1010
import psutil
11-
from PyQt5 import QtWidgets
11+
from PyQt6 import QtWidgets
1212

1313
import online_monitor
1414
from online_monitor import OnlineMonitor

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ dependencies = [
2121
"pyyaml", # configuration parsing
2222
"psutil", # to get process stats
2323
"pyqtgraph>=0.13", # plotting library
24-
"pyqt5>=5.15.10",
24+
"PyQt6",
2525
"pytest",
2626
"matplotlib", # generate colormaps for lookuptables
2727
"testfixtures", # for unittests with logging output inspection

0 commit comments

Comments
 (0)