Revert "Move overlay to Cache directory"

This reverts commit 1052bf7.

Due to resources within Cache/ being loaded before Packages/, alias syntaxes'
file extension specifications didn't always take desired precedence over default
syntaxes. Hence overlay package location needs to be reverted, to ensure
expected icons to be displayed.

Example:

Python/Python.sublime-syntax is assigned to ".bzl" file extension.

A File Icon ships a Python (Bazel).sublime-syntax with a dedicated source.bazel
scope associated with ".bzl" extension as well.

For the latter to take precedence, it must be loaded after Python, which isn't
the case, when located in Cache/, regardless the "zzz A File Icon" package name.

Author: deathaxe

core/aliases.py

@@ -89,6 +89,7 @@ def delete_alias_files(syntaxes):
 
     def remove():
         shutil.rmtree(path.overlay_aliases_path(), ignore_errors=True)
+        shutil.rmtree(path.overlay_cache_path(), ignore_errors=True)
 
     sublime.set_timeout_async(remove)
 

core/utils/path.py

@@ -22,24 +22,28 @@ def package_icons_path():
 
 
 def overlay_path():
+    return os.path.join(sublime.packages_path(), OVERLAY_ROOT)
+
+
+def overlay_cache_path():
     return os.path.join(sublime.cache_path(), OVERLAY_ROOT)
 
 
 def overlay_aliases_path(file_name=""):
-    return os.path.join(sublime.cache_path(), OVERLAY_ROOT, "aliases", file_name)
+    return os.path.join(sublime.packages_path(), OVERLAY_ROOT, "aliases", file_name)
 
 
 def overlay_patches_path():
-    return os.path.join(sublime.cache_path(), OVERLAY_ROOT, "patches")
+    return os.path.join(sublime.packages_path(), OVERLAY_ROOT, "patches")
 
 
 def overlay_patches_general_path():
-    return os.path.join(sublime.cache_path(), OVERLAY_ROOT, "patches", "general")
+    return os.path.join(sublime.packages_path(), OVERLAY_ROOT, "patches", "general")
 
 
 def overlay_patches_specific_path():
-    return os.path.join(sublime.cache_path(), OVERLAY_ROOT, "patches", "specific")
+    return os.path.join(sublime.packages_path(), OVERLAY_ROOT, "patches", "specific")
 
 
 def overlay_aliases_resource_path(file_name=""):
-    return "Cache/{}/aliases/{}".format(OVERLAY_ROOT, file_name)
+    return "Packages/{}/aliases/{}".format(OVERLAY_ROOT, file_name)