Fix not returing safe arrays decoupled from netty's buffer

Author: SynesthesiaDev

Codon.BinaryCodec/BinaryCodecs.cs

@@ -143,7 +143,7 @@ public void Write(IByteBuffer buffer, byte[] value)
         public byte[] Read(IByteBuffer buffer)
         {
             var size = BinaryCodec.VAR_INT.Read(buffer);
-            return buffer.ReadBytes(size).Array;
+            return buffer.ReadBytes(size).ToByteArraySafe(size);
         }
     }
 
@@ -176,7 +176,7 @@ public string Read(IByteBuffer buffer)
         {
             var size = BinaryCodec.VAR_INT.Read(buffer);
             if (size < 0) throw new InvalidDataException("String cannot have negative length");
-            var stringBytes = buffer.ReadBytes(size).Array;
+            var stringBytes = buffer.ReadBytes(size).ToByteArraySafe();
             return Encoding.UTF8.GetString(stringBytes);
         }
     }
@@ -190,7 +190,7 @@ public void Write(IByteBuffer buffer, byte[] value)
 
         public byte[] Read(IByteBuffer buffer)
         {
-            return buffer.ReadBytes(buffer.Array.Length).Array;
+            return buffer.ReadBytes(buffer.Array.Length).ToByteArraySafe();
         }
     }
 

Codon.BinaryCodec/ByteBufferExtensions.cs

@@ -0,0 +1,24 @@
+// Copyright (c) 2026 SynesthesiaDev <synesthesiadev@proton.me>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using System;
+using DotNetty.Buffers;
+
+namespace Codon.Binary;
+
+public static class ByteBufferExtensions
+{
+    public static byte[] ToByteArraySafe(this IByteBuffer buffer, int size)
+    {
+        var destination = new byte[size];
+        buffer.ReadBytes(destination);
+        return destination;
+    }
+
+    public static byte[] ToByteArraySafe(this IByteBuffer buffer)
+    {
+        int size = Math.Max(0, buffer.ReadableBytes);
+        return buffer.ToByteArraySafe(size);
+    }
+
+}