fix(marko-virtual): consolidate Marko e2e into one in-package app, fix test (#1243)

Author: piecyk

.changeset/marko-e2e-consolidation.md

@@ -0,0 +1,12 @@
+---
+'@tanstack/marko-virtual': patch
+---
+
+Stop publishing the tags build's incremental state: `marko-type-check` writes
+`dist/tsconfig.tags.tsbuildinfo`, which the `files` field shipped to npm and nx
+cached as part of `dist`. Because `@marko/type-check` always runs incrementally, a
+`dist` that carried that file but not `dist/tags` (which `marko.json` points at)
+made every subsequent build a silent no-op — exit 0, nothing emitted — and any
+consumer then failed to compile with
+`ENOENT: no such file or directory, scandir '.../dist/tags'`. The build now removes
+the file after emitting, so a build always produces `dist/tags`.

.gitignore

@@ -46,4 +46,7 @@ vite.config.ts.timestamp-*
 test-results/
 playwright-report/
 *.log
-**/*.tsbuildinfo
+**/*.tsbuildinfo
+
+# Marko Run generated route types
+.marko-run/

examples/marko/chat-pretext/.marko-run/routes.d.ts

@@ -6,7 +6,6 @@
     "dev": "marko-run dev",
     "build": "marko-run build",
     "preview": "marko-run preview",
-    "test:e2e": "playwright test",
     "test:types": "marko-type-check"
   },
   "dependencies": {
@@ -18,7 +17,6 @@
   "devDependencies": {
     "@marko/language-tools": "^2.6.2",
     "@marko/type-check": "3.1.1",
-    "@playwright/test": "^1.53.1",
     "typescript": "5.9.3",
     "vite": "^6.4.2"
   }

examples/marko/chat-pretext/e2e/README.md

@@ -133,6 +133,14 @@ static function messageHeight(message: Message, viewportWidth: number) {
       pinnedInitially: false,
       autoHistoryArmed: false,
       autoHistoryEnabled: false,
+      // "Latest" in flight: keep re-pinning until the end is actually reached. A
+      // single scrollToEnd() can land and then be carried away — e.g. an in-flight
+      // history prepend (180ms timer) resolving AFTER the jump grows the content
+      // above the viewport, and if core's offset read is stale at that moment its
+      // at-end compensation is skipped — so the view strands ~12 rows short with no
+      // scroll event to recover it. The reactive <script> below re-issues the jump
+      // on every virtualizer update until the end holds, then disarms.
+      pinPending: false,
       streamAbort: null as AbortController | null,
       width: DEFAULT_VIEWPORT_WIDTH,
     })/>
@@ -167,6 +175,7 @@ static function messageHeight(message: Message, viewportWidth: number) {
     // the initial settle. Same pattern as the Chat example.
     <script() {
       if (!state.pinnedInitially && v.range) {
+        state.pinPending = true
         v.scrollToEnd()
         atEnd = true
         state.pinnedInitially = true
@@ -183,6 +192,18 @@ static function messageHeight(message: Message, viewportWidth: number) {
       if (statusEl) {
         atEnd = statusEl.scrollHeight - statusEl.scrollTop - statusEl.clientHeight <= AT_END_PX
       }
+      // Converge an in-flight "Latest": re-issue the jump while content growth keeps
+      // moving the end away (see pinPending above). Disarms once the end holds AND no
+      // history load is in flight — a prepend armed before the click can land after
+      // the end was first reached, and disarming early would leave that late growth
+      // with no corrective jump.
+      if (state.pinPending) {
+        if (atEnd && !loadingHistory) {
+          state.pinPending = false
+        } else if (!atEnd) {
+          v.scrollToEnd()
+        }
+      }
     }/>
 
     <div class="toolbar">
@@ -238,7 +259,10 @@ static function messageHeight(message: Message, viewportWidth: number) {
             }
           })()
         }>Stream reply</button>
-        <button data-testid="latest" onClick() { v.scrollToEnd() }>Latest</button>
+        <button data-testid="latest" onClick() {
+          state.pinPending = true
+          v.scrollToEnd()
+        }>Latest</button>
       </div>
       <div class="status" data-testid="status">
         ${loadingHistory ? 'Loading history' : atEnd ? 'At latest' : 'Reading history'}

examples/marko/chat-pretext/package.json

@@ -13,8 +13,6 @@
   },
   "include": [
     "src",
-    "e2e",
-    "playwright.config.ts",
     "vite.config.ts",
     "../../../packages/marko-virtual/src/tags/**/*"
   ]