From 8ab1d001d21fcfc6c57fd46d41742797d20aa63f Mon Sep 17 00:00:00 2001 From: wei <104672881+shengzhaowei@users.noreply.github.com> Date: Sat, 21 Nov 2026 13:53:34 +0800 Subject: [PATCH] feat(local): record executor_id and result in finish events --- .../skills/devflow/scripts/workflow_state.py | 8 ++++- .../skills/devflow/tests/test_regressions.py | 30 +++++++++++++++++++ 2 files changed, 37 insertions(+), 1 deletion(-) mode change 100755 => 100644 local/skills/devflow/scripts/workflow_state.py diff --git a/local/skills/devflow/scripts/workflow_state.py b/local/skills/devflow/scripts/workflow_state.py old mode 100755 new mode 100644 index 924243091..197c3176a --- a/local/skills/devflow/scripts/workflow_state.py +++ b/local/skills/devflow/scripts/workflow_state.py @@ -772,7 +772,13 @@ def command_finish(args: argparse.Namespace) -> int: else: data["next_stage"] = args.stage data["updated_at"] = stamp - data["events"].append({"at": stamp, "event": f"stage_{args.result}", "stage": args.stage}) + data["events"].append({ + "at": stamp, + "event": f"stage_{args.result}", + "stage": args.stage, + "executor_id": stage.get("executor_id"), + "result": args.result, + }) atomic_write(args.state, data) if data.get("awaiting_approval"): print( diff --git a/local/skills/devflow/tests/test_regressions.py b/local/skills/devflow/tests/test_regressions.py index 7794cc143..b659ea8a9 100644 --- a/local/skills/devflow/tests/test_regressions.py +++ b/local/skills/devflow/tests/test_regressions.py @@ -534,6 +534,36 @@ def test_solo_overflow_leaves_a_resumable_medium_state(self): self.assertEqual("medium", state["size_class"]) self.assertEqual("skipped", state["stages"]["SOLO"]["status"]) + def test_finish_event_records_executor_id_and_result(self): + with tempfile.TemporaryDirectory() as directory: + root = Path(directory) + state_path = Path(run_script( + "workflow_state.py", "init", "--project-root", root, + "--slug", "finish-trace", "--size", "small", "--mode", "auto", + "--execution-mode", "isolated", "--host-adapter", "claude", + "--coordinator-id", "main", + ).stdout.strip()) + run_script("workflow_state.py", "prepare", "--state", state_path, "--stage", "SOLO") + run_script( + "workflow_state.py", "assign", "--state", state_path, "--stage", "SOLO", + "--role", STAGE_ROLES["SOLO"], "--executor-type", "devflow-stage-executor", + "--executor-id", "solo-1", "--dispatch-tool", "agent", + ) + run_script("workflow_state.py", "start", "--state", state_path, "--stage", "SOLO") + self.fill_stage_artifacts(state_path, "SOLO") + run_script( + "workflow_state.py", "finish", "--state", state_path, "--stage", "SOLO", + "--result", "completed", + ) + state = json.loads(state_path.read_text(encoding="utf-8")) + finished = [ + event for event in state["events"] + if event.get("event") == "stage_completed" and event.get("stage") == "SOLO" + ] + self.assertEqual(1, len(finished)) + self.assertEqual("solo-1", finished[0].get("executor_id")) + self.assertEqual("completed", finished[0].get("result")) + def test_large_keeps_knowledge_and_legacy_medium_route_remains_valid(self): with tempfile.TemporaryDirectory() as directory: root = Path(directory)