Skip to content

Commit 985e174

Browse files
committed
SITES-49657 - Release CIF components 2.18.6
* map MAVEN_CENTRAL_USERNAME / MAVEN_CENTRAL_PASSWORD into the release job env, so the settings.xml placeholders for the Sonatype Central Portal server resolve instead of being sent literally (HTTP 401 on the 2.18.6 release run) * document the two secrets in the workflow header * add a skip.npm.publish property (default false) and honour it on the three npm-module-publish executions, so a release deploy can be re-run when the npm packages of that version are already published
1 parent 5ec71aa commit 985e174

5 files changed

Lines changed: 9 additions & 0 deletions

File tree

.github/workflows/release.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#
88
# Required secrets:
99
# ARTIFACTORY_CLOUD_USER, ARTIFACTORY_CLOUD_PASS - Adobe Artifactory (.github/scripts/settings.xml)
10+
# MAVEN_CENTRAL_USERNAME, MAVEN_CENTRAL_PASSWORD - Sonatype Central Portal (.github/scripts/settings.xml)
1011
# NPM_TOKEN - npm publish
1112
# GPG_PRIVATE_KEY, GPG_PASSPHRASE - artifact signing
1213
# DEPLOY_QUERIES_SSH_KEY - deploy key with push access to
@@ -79,6 +80,8 @@ jobs:
7980
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
8081
ARTIFACTORY_CLOUD_USER: ${{ secrets.ARTIFACTORY_CLOUD_USER }}
8182
ARTIFACTORY_CLOUD_PASS: ${{ secrets.ARTIFACTORY_CLOUD_PASS }}
83+
MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
84+
MAVEN_CENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
8285

8386
- name: Clean up secrets
8487
if: always()

extensions/experience-platform-connector/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@
109109
<goal>npm</goal>
110110
</goals>
111111
<configuration>
112+
<skip>${skip.npm.publish}</skip>
112113
<arguments>publish</arguments>
113114
</configuration>
114115
</execution>

extensions/product-recs/react-components/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@
109109
<goal>npm</goal>
110110
</goals>
111111
<configuration>
112+
<skip>${skip.npm.publish}</skip>
112113
<arguments>publish</arguments>
113114
</configuration>
114115
</execution>

parent/pom.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,9 @@
116116
<!-- By default, webpack will build in development mode -->
117117
<webpack.prod>false</webpack.prod>
118118
<webpack.dev>true</webpack.dev>
119+
120+
<!-- Set to true to re-run a release deploy whose npm packages are already published -->
121+
<skip.npm.publish>false</skip.npm.publish>
119122
</properties>
120123

121124
<!-- ====================================================================== -->

react-components/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@
109109
<goal>npm</goal>
110110
</goals>
111111
<configuration>
112+
<skip>${skip.npm.publish}</skip>
112113
<arguments>publish</arguments>
113114
</configuration>
114115
</execution>

0 commit comments

Comments
 (0)