FINERACT-2713: Bind untyped report parameters numerically so Postgres cascades work

- Since FINERACT-2624 switched report-parameter substitution from string interpolation to
  JDBC bind variables, a placeholder that appears in a report's SQL but is not one of that
  report's own declared parameters binds as a String. On PostgreSQL, comparing a bigint
  column to a bound character varying raises "operator does not exist: bigint = character
  varying" and the query fails with HTTP 403; MySQL and MariaDB coerce the types silently,
  which is why CI does not see it.
- The stock loanOfficerIdSelectAll option lookup is the clearest case. Its SQL filters
  "... and o.id = ${officeId}", where officeId is supplied by the parent parameter, so
  ReadReportingServiceImpl.getSQLtoRun loads the format types of loanOfficerIdSelectAll,
  finds no entry for officeId, and castParamValue falls through to returning the raw
  String. Every report whose Loan Officer dropdown cascades off office is therefore empty
  on a PostgreSQL deployment.
- When no format type is declared, infer a numeric bind for a plain integer value so
  strict engines compare correctly. The inference is deliberately narrow: the value must
  match -?(0|[1-9]\d*), so currency codes, free text and identifiers carrying leading
  zeros such as 000123 keep their String binding and are not mangled into numbers.
  Declared NUMBER, INTEGER and DATE types are untouched.
- Add ReadReportingServiceImplTest, which captures the values bound for a report whose SQL
  cascades on ${officeId}: an untyped "1" must arrive as a Long, while "USD" and "000123"
  must stay Strings and a declared number type must keep working. The first case fails on
  the unfixed code with "expected: java.lang.Long<1> but was: java.lang.String<1>"; the
  other three assert the narrowness of the inference and hold either way by design.

Signed-off-by: oluexpert99 <farooq@techservicehub.io>

Author: oluexpert99

fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingServiceImpl.java

@@ -87,6 +87,9 @@ public class ReadReportingServiceImpl implements ReadReportingService {
     /** Matches any {@code ${placeholderName}} token in a report SQL template. */
     private static final Pattern PLACEHOLDER_PATTERN = Pattern.compile("\\$\\{([^}]+)\\}");
 
+    /** A plain integer with no leading zeros, so identifiers like {@code 000123} stay strings. */
+    private static final Pattern UNTYPED_INTEGER = Pattern.compile("-?(0|[1-9]\\d*)");
+
     private final JdbcTemplate jdbcTemplate;
     private final PlatformSecurityContext context;
     private final GenericDataService genericDataService;
@@ -162,6 +165,18 @@ private Object castParamValue(String value, String formatType) {
         if ("DATE".equalsIgnoreCase(formatType)) {
             return java.sql.Date.valueOf(value);
         }
+        // No declared format type — typically an office/product-cascaded lookup parameter
+        // substituted into another report's SQL (e.g. ${officeId} inside loanOfficerIdSelectAll).
+        // Bind a plain integer as a number so strict engines compare correctly; Postgres, unlike
+        // MySQL, rejects "bigint = varchar". Everything else (currency codes, ids with leading
+        // zeros, free text) stays a string.
+        if ((formatType == null || formatType.isBlank()) && UNTYPED_INTEGER.matcher(value).matches()) {
+            try {
+                return Long.parseLong(value);
+            } catch (NumberFormatException e) {
+                return value;
+            }
+        }
         return value;
     }
 

fineract-provider/src/test/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingServiceImplTest.java

@@ -0,0 +1,136 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.infrastructure.dataqueries.service;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+import java.util.Map;
+import org.apache.fineract.infrastructure.core.config.FineractProperties;
+import org.apache.fineract.infrastructure.core.service.database.DatabaseSpecificSQLGenerator;
+import org.apache.fineract.infrastructure.dataqueries.data.GenericResultsetData;
+import org.apache.fineract.infrastructure.report.service.ReportParameterTypeResolver;
+import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext;
+import org.apache.fineract.infrastructure.security.service.SqlInjectionPreventerService;
+import org.apache.fineract.useradministration.domain.AppUser;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentCaptor;
+import org.springframework.jdbc.core.JdbcTemplate;
+import org.springframework.jdbc.support.rowset.SqlRowSet;
+
+/**
+ * Binding of report parameters that have no declared format type — the cascaded-lookup case behind FINERACT-2713.
+ */
+class ReadReportingServiceImplTest {
+
+    private static final String REPORT_NAME = "loanOfficerIdSelectAll";
+    // A cascaded lookup: ${officeId} comes from the PARENT parameter, so this report does not declare it.
+    private static final String REPORT_SQL = "select lo.id, lo.display_name as name from m_staff lo "
+            + "join m_office o on o.id = lo.office_id where lo.is_loan_officer = true and o.id = ${officeId}";
+
+    private JdbcTemplate jdbcTemplate;
+    private GenericDataService genericDataService;
+    private ReportParameterTypeResolver reportParameterTypeResolver;
+    private ReadReportingServiceImpl service;
+
+    @BeforeEach
+    void setUp() {
+        jdbcTemplate = mock(JdbcTemplate.class);
+        genericDataService = mock(GenericDataService.class);
+        reportParameterTypeResolver = mock(ReportParameterTypeResolver.class);
+        PlatformSecurityContext context = mock(PlatformSecurityContext.class, RETURNS_DEEP_STUBS);
+        DatabaseSpecificSQLGenerator sqlGenerator = mock(DatabaseSpecificSQLGenerator.class);
+        SqlInjectionPreventerService sqlInjectionPreventerService = mock(SqlInjectionPreventerService.class);
+        FineractProperties fineractProperties = mock(FineractProperties.class, RETURNS_DEEP_STUBS);
+
+        AppUser user = mock(AppUser.class, RETURNS_DEEP_STUBS);
+        when(user.getId()).thenReturn(1L);
+        when(user.getOffice().getHierarchy()).thenReturn(".");
+        when(context.authenticatedUser()).thenReturn(user);
+
+        when(sqlGenerator.currentBusinessDate()).thenReturn("'2024-01-01'");
+        when(sqlGenerator.currentTenantDateTime()).thenReturn("'2024-01-01 00:00:00'");
+        when(sqlInjectionPreventerService.encodeSql(anyString())).thenAnswer(call -> call.getArgument(0));
+
+        // the report SQL lookup
+        SqlRowSet rowSet = mock(SqlRowSet.class);
+        when(rowSet.next()).thenReturn(true);
+        when(rowSet.getString("the_sql")).thenReturn(REPORT_SQL);
+        when(jdbcTemplate.queryForRowSet(anyString(), eq(REPORT_NAME))).thenReturn(rowSet);
+
+        // pass SQL through untouched so the assertion is about the bound values, not the rewriting
+        when(genericDataService.wrapSQL(anyString())).thenAnswer(call -> call.getArgument(0));
+        when(genericDataService.replace(anyString(), anyString(), anyString())).thenAnswer(call -> call.getArgument(0));
+        when(genericDataService.fillGenericResultSet(anyString(), any())).thenReturn(mock(GenericResultsetData.class));
+
+        service = new ReadReportingServiceImpl(jdbcTemplate, context, genericDataService, sqlInjectionPreventerService, sqlGenerator,
+                fineractProperties, reportParameterTypeResolver);
+    }
+
+    private Object[] boundParamsFor(Map<String, String> queryParams) {
+        service.retrieveGenericResultset(REPORT_NAME, "report", queryParams);
+        ArgumentCaptor<Object[]> captor = ArgumentCaptor.forClass(Object[].class);
+        verify(genericDataService).fillGenericResultSet(anyString(), captor.capture());
+        return captor.getValue();
+    }
+
+    // FINERACT-2713: a cascaded parameter is absent from the running report's own format-type map, so it used to bind
+    // as a String. PostgreSQL rejects "bigint = character varying" (MySQL silently coerces it), leaving the dependent
+    // dropdown empty. A plain integer with no declared type must bind numerically.
+    @Test
+    void untypedIntegerParameterBindsAsNumber() {
+        when(reportParameterTypeResolver.loadParamFormatTypes(REPORT_NAME)).thenReturn(Map.of()); // officeId not declared
+
+        Object[] bound = boundParamsFor(Map.of("officeId", "1"));
+
+        assertEquals(1, bound.length);
+        assertEquals(Long.valueOf(1L), bound[0], "an untyped plain integer must bind as a number, not a String");
+    }
+
+    // The inference must stay narrow: anything that is not a plain integer keeps its String binding, so currency
+    // codes and identifiers carrying leading zeros are not silently mangled into numbers.
+    @Test
+    void untypedNonIntegerParameterStaysAString() {
+        when(reportParameterTypeResolver.loadParamFormatTypes(REPORT_NAME)).thenReturn(Map.of());
+
+        assertEquals("USD", boundParamsFor(Map.of("officeId", "USD"))[0]);
+    }
+
+    @Test
+    void untypedIntegerWithLeadingZerosStaysAString() {
+        when(reportParameterTypeResolver.loadParamFormatTypes(REPORT_NAME)).thenReturn(Map.of());
+
+        assertEquals("000123", boundParamsFor(Map.of("officeId", "000123"))[0], "leading zeros are significant in identifiers");
+    }
+
+    // A declared type still wins — this path is untouched by the fix.
+    @Test
+    void declaredNumberParameterStillBindsAsNumber() {
+        when(reportParameterTypeResolver.loadParamFormatTypes(REPORT_NAME)).thenReturn(Map.of("officeId", "number"));
+
+        assertEquals(Long.valueOf(7L), boundParamsFor(Map.of("officeId", "7"))[0]);
+    }
+}