Repository navigation
fix(validate): only suppress warning rules in --suppressAllWarnings - #2341
Open
hoanle0126 wants to merge 1 commit into
Open
hoanle0126 wants to merge 1 commit into
hoanle0126 wants to merge 1 commit into
Conversation
hoanle0126
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns,
asyncapi-bot-eve and
princerajpoot20
as code owners
November 7, 2026 01:44
🦋 Changeset detectedLatest commit: 6f122a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
d.severity === DiagnosticSeverity.WarninginValidationService.buildParserWithAllWarningsSuppressed(src/domains/services/validation.service.ts) so--suppressAllWarningsno longer disables error, information, or hint rules (preventing schema-invalid specifications from passing validation with exit code 0).buildParserWithSpecificWarningsSuppressedso non-extendable diagnostic codes (such asinvalid-ref) never throwCannot extend non-existing rule.test/unit/services/validation.service.test.tsandtest/integration/validate.test.ts, plus a patch changeset.Related issue(s)
Resolves #2340