Repository navigation
Commit a35d79c
committed
docs(readme): state the host dependency of the timings, and that colbymchenry#1715 supersedes the bare-import row
Two things a reader cannot check from the table.
The millisecond figures depend on a machine-local Windows Defender exclusion.
The corpus sat under an excluded directory and the interpreter in Program
Files; on this host an unexcluded directory read by an untrusted binary costs
~12.6s for one 1.2MB file. All three arms shared the configuration so the
comparison holds, but the absolute totals do not transfer to a stock host.
And the bare-import row is no longer the best available fix. colbymchenry#1715 moves the
guard into matchByExactName, where these references actually resolve, and
measured on the same corpus against the same merge base it removes 2,487 edge
rows to this change's 4, adding none. All 2,487 have a source file importing
that name from a bare npm package or node builtin, so the removals are
precision gains rather than a regression.1 parent 05a9d2d commit a35d79c
1 file changed
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
106 | 113 | | |
107 | 114 | | |
108 | 115 | | |
| |||
134 | 141 | | |
135 | 142 | | |
136 | 143 | | |
137 | | - | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
138 | 150 | | |
139 | 151 | | |
140 | 152 | | |
| |||
0 commit comments