Skip to content

Commit 379c583

Browse files
committed
Fix cadvisor scraping
1 parent 4ab8bc2 commit 379c583

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

docker-compose.swarm.nodb.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -261,14 +261,19 @@ services:
261261
# the false-quarantine incident: long-lived daemons inside containers (clamd)
262262
# were invisible to both host-level and per-subprocess measurements.
263263
cadvisor:
264-
image: gcr.io/cadvisor/cadvisor:v0.52.1
264+
# v0.55+: v0.52 chokes on Docker 29's containerd image store (rw-layer
265+
# lookup fails -> ALL metrics for those containers silently dropped).
266+
image: gcr.io/cadvisor/cadvisor:v0.55.1
265267
command:
266268
- '--docker_only=true'
267269
- '--housekeeping_interval=15s'
268270
- '--store_container_labels=false'
269271
# keep only this label: needed to group metrics per swarm service
270272
- '--whitelisted_container_labels=com.docker.swarm.service.name'
271-
- '--disable_metrics=percpu,sched,tcp,udp,advtcp,process,hugetlb,referenced_memory,cpu_topology,resctrl'
273+
# disk/diskIO also disabled: the rw-layer lookup they require breaks
274+
# on Docker 29's containerd image store (no overlayfs/layerdb path),
275+
# which silently drops ALL metrics for those containers.
276+
- '--disable_metrics=percpu,sched,tcp,udp,advtcp,process,hugetlb,referenced_memory,cpu_topology,resctrl,disk,diskIO'
272277
volumes:
273278
- /:/rootfs:ro
274279
- /var/run:/var/run:ro

docker/prometheus/prometheus.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,5 +37,7 @@ scrape_configs:
3737
# Per-container memory/CPU. Closes the gap that made the clamd incident
3838
# possible: long-lived daemons inside containers were invisible.
3939
- job_name: "cadvisor"
40-
static_configs:
41-
- targets: ["cadvisor:8080"]
40+
dns_sd_configs:
41+
- names: ["tasks.cadvisor"]
42+
type: A
43+
port: 8080

0 commit comments

Comments
 (0)