Add flag to skip comments from duplication analyses - #69
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 2 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
While the PR implements the requested --skip-comments flag, it also introduces an undocumented and hardcoded 150kb file size limit (--max-size). This change was not mentioned in the PR title or description and could lead to large files being silently ignored during duplication analysis. Codacy reports the PR is up to standards, but the lack of tests for the new command-line arguments and the empty PR description are concerns that should be addressed before merging.
About this PR
- Scope misalignment: The PR title mentions skipping comments, but the implementation also adds a hardcoded '--max-size' limit of 150kb. This additional logic should be documented or made configurable to avoid unexpected behavior in projects with large files.
- The PR description is empty. Please provide context for the changes, specifically explaining the inclusion of the hardcoded 150kb size limit which was not part of the PR title.
Test suggestions
- Missing recommended test scenario: Verify that the jscpd command includes the '--skip-comments' flag when executed.
- Missing recommended test scenario: Verify that the jscpd command includes the '--max-size' flag with the value '150kb'.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Missing recommended test scenario: Verify that the jscpd command includes the '--skip-comments' flag when executed.
2. Missing recommended test scenario: Verify that the jscpd command includes the '--max-size' flag with the value '150kb'.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
No description provided.