From 6880d0f9125d5d749ad75ea2353fef3195b25c95 Mon Sep 17 00:00:00 2001 From: anurag629 Date: Thu, 15 Oct 2026 14:42:30 +0530 Subject: [PATCH] docs: ask for bug fix tests that fail without the fix --- .github/PULL_REQUEST_TEMPLATE.md | 1 + CONTRIBUTING.md | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 69fa85d..5066a2d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -33,6 +33,7 @@ Closes # - [ ] I was assigned the linked issue - [ ] `npm run check` passes - [ ] `npm run test` passes +- [ ] For a bug fix: the new test fails without my change - [ ] Tested locally with `npm run dev` - [ ] Screenshots included for visual changes - [ ] New templates follow the [Template Guidelines](https://github.com/codercops/ogcops/blob/dev/CONTRIBUTING.md#template-guidelines) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9cbb7a0..c520883 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,6 +44,8 @@ Two spam PRs and you won't be assigned more issues this month, and you're out of Every PR needs a "How I tested this" line: what you ran or clicked through to check it works. +For a bug fix, check that your new test fails without the fix: undo the change in the source, run the tests, then put it back. A test that passes either way doesn't catch anything. + I review most PRs within a few days. Please don't ping repeatedly or DM maintainers about a review. If three days pass with no reply, one follow-up comment on the PR is fine. ### Goodies