Changes for the theme review

- don't bundle js
- prefix various functions and output
- fix screenshot
- remove the theme url
- remove footer link
- use core jquery

Author: Cresencio Cantu

README.txt

@@ -1,68 +1,36 @@
-Skip to content
- 
-Search or jump to…
+=== A Starting Point ===
+Contributors: can2
+Requires at least: 5.0
+Tested up to: 5.2
+Requires PHP: 5.6
+License: GPLv2 or later
+License URI: http://www.gnu.org/licenses/gpl-2.0.html
 
-Pull requests
-Issues
-Marketplace
-Explore
- 
-@cresencio 
-0
-0 0 cresencio/asp-theme
- Code  Issues 0  Pull requests 0  Projects 0  Wiki  Insights  Settings
-asp-theme/readme.txt
- Cresencio Cantu initial commit
-e31d2a6 on Mar 19
-39 lines (24 sloc)  1.09 KB
-    
-=== ASP Theme ===
-
-Contributors: automattic
-Tags: custom-background, custom-logo, custom-menu, featured-images, threaded-comments, translation-ready
-
-Requires at least: 4.5
-Tested up to: 4.8
-Stable tag: 1.0.0
-License: GNU General Public License v2 or later
-License URI: LICENSE
-
-A starter theme called ASP Theme.
+A Starting Point is an "_s" or underscores based theme with some extra features.
 
 == Description ==
+A Starting Point is an "_s" or underscores based theme with some extra features. Extra features include additional widget areas for the sidebar and footer and additional styles.
 
-A starter theme for WordPress.
-
-== Installation ==
+== Frequently Asked Questions ==
 
-1. In your admin panel, go to Appearance > Themes and click the Add New button.
-2. Click Upload Theme and Choose File, then select the theme's .zip file. Click Install Now.
-3. Click Activate to use your new theme right away.
+= Does this theme use a front-end framework? =
 
-== Frequently Asked Questions ==
+Yes, this theme includes a full copy of the latest version of Bootstrap.
 
 = Does this theme support any plugins? =
 
-ASP Theme includes support for Infinite Scroll in Jetpack.
+Yes, this theme supports the following plugins:
+
+- Advanced Custom Fields
+- WooCommerce
 
 == Changelog ==
 
-= 1.0 - May 12 2015 =
-* Initial release
+= 1.0.0 =
+* Initial release.
 
-== Credits ==
 
-* Based on Underscores https://underscores.me/, (C) 2012-2017 Automattic, Inc., [GPLv2 or later](https://www.gnu.org/licenses/gpl-2.0.html)
-* normalize.css https://necolas.github.io/normalize.css/, (C) 2012-2016 Nicolas Gallagher and Jonathan Neal, [MIT](https://opensource.org/licenses/MIT)
-© 2019 GitHub, Inc.
-Terms
-Privacy
-Security
-Status
-Help
-Contact GitHub
-Pricing
-API
-Training
-Blog
-About
+== Resources ==
+* _s - http://underscores.me/
+* Bootstrap - https://getbootstrap.com/
+* Advanced Custom Fields - http://advancedcustomfields.com/

footer.php

@@ -27,11 +27,6 @@
 							printf( esc_html__( 'Proudly powered by %s', 'a-starting-point' ), 'WordPress' );
 							?>
 						</a>
-						<span class="sep"> | </span>
-							<?php
-							/* translators: 1: Theme name, 2: Theme author. */
-							printf( esc_html__( 'Theme: %1$s available on %2$s.', 'a-starting-point' ), 'A Starting Point', '<a href="https://github.com/cresencio/asp-theme">GitHub</a>' );
-							?>
 					</div><!-- .site-info -->
 			</div>
 		</div>

functions.php

@@ -139,9 +139,13 @@ function a_starting_point_widgets_init() {
  */
 function a_starting_point_scripts() {
 
-	wp_enqueue_style( 'style', get_stylesheet_uri() );
-	wp_enqueue_script( 'header_js', get_template_directory_uri() . '/js/header-bundle.js', null, 1.0, false );
-	wp_enqueue_script( 'footer_js', get_template_directory_uri() . '/js/footer-bundle.js', null, 1.0, true );
+	wp_enqueue_style( 'a_starting_point_style', get_stylesheet_uri() );
+	wp_enqueue_script( 'jquery');
+	wp_enqueue_script( 'a_starting_point_popper', get_template_directory_uri() . '/js/popper.js', null, 1.15, true );
+	wp_enqueue_script( 'a_starting_point_bootstrap', get_template_directory_uri() . '/js/bootstrap.js', null, 4.3, true );
+	wp_enqueue_script( 'a_starting_point_navigation', get_template_directory_uri() . '/js/navigation.js', null, 1.0, true );
+	wp_enqueue_script( 'a_starting_point_-skip-link-focus-fix', get_template_directory_uri() . '/js/skip-link-focus-fix.js', array(), '20151215', true );
+
 
 	if ( is_singular() && comments_open() && get_option( 'thread_comments' ) ) {
 		wp_enqueue_script( 'comment-reply' );
@@ -197,27 +201,27 @@ function a_starting_point_scripts() {
 
 // add the BS nav class to all menus
 
-function add_bs_nav_class_to_menus( $args )
+function a_starting_point_add_bs_nav_class_to_menus( $args )
 {
 	$args['menu_class'] .= ' nav';
 	return $args;
 }
 
-add_filter( 'wp_nav_menu_args', 'add_bs_nav_class_to_menus' );
+add_filter( 'wp_nav_menu_args', 'a_starting_point_add_bs_nav_class_to_menus' );
 
 // add BS nav-item class to all li tags
-function add_bs_link_item_class_to_list_items($classes, $item, $args) {
+function a_starting_point_add_bs_link_item_class_to_list_items($classes, $item, $args) {
   $classes[] = 'nav-item';
   return $classes;
 }
-add_filter('nav_menu_css_class', 'add_bs_link_item_class_to_list_items', 1, 3);
+add_filter('nav_menu_css_class', 'a_starting_point_add_bs_link_item_class_to_list_items', 1, 3);
 
 // add the BS nav-link class to all menu links
-function add_bs_nav_link_class_to_menu_links($atts) {
+function a_starting_point_add_bs_nav_link_class_to_menu_links($atts) {
   $atts['class'] = "nav-link";
   return $atts;
 }
-add_filter( 'nav_menu_link_attributes', 'add_bs_nav_link_class_to_menu_links');
+add_filter( 'nav_menu_link_attributes', 'a_starting_point_add_bs_nav_link_class_to_menu_links');
 
 if ( ! function_exists( 'wp_body_open' ) ) :
 	/**

header.php

@@ -61,7 +61,7 @@
 
 					<nav id="site-navigation" class="main-navigation">
 
-						<button class="menu-toggle" aria-controls="primary-menu" aria-expanded="false"><?php esc_html_e( 'menu toggle', 'a-starting-point' ); ?></button>
+						<button class="menu-toggle" aria-controls="primary-menu" aria-expanded="false"><?php esc_html_e( 'menu', 'a-starting-point' ); ?></button>
 						<?php
 
 						wp_nav_menu( array(

inc/acf-filters.php

@@ -16,43 +16,26 @@ function a_starting_point_acf_widget_custom_class( $params ) {
 	$widget_name = $params[0]['widget_name'];
 	$widget_id = $params[0]['widget_id'];
 	// get acf value
-	$custom_css_class_value = a_starting_point_clean_acf_text_fields(get_field('asp_custom_widget_class', 'widget_' . $widget_id));
+	$a_starting_point_custom_css_class_value = a_starting_point_clean_acf_text_fields(get_field('asp_custom_widget_class', 'widget_' . $widget_id));
 
-	if( $custom_css_class_value ) {
-		$params[0]['before_widget'] = str_replace( 'asp-theme-acf', esc_html( $custom_css_class_value ), $params[0]['before_widget'] );
+	if( $a_starting_point_custom_css_class_value ) {
+		$params[0]['before_widget'] = str_replace( 'asp-theme-acf', esc_html( $a_starting_point_custom_css_class_value ), $params[0]['before_widget'] );
 	}
 	// return
 	return $params;
 }
 add_filter('dynamic_sidebar_params', 'a_starting_point_acf_widget_custom_class');
 
-// add custom field value to menu class if it exists, also add icon for menu items
+// add custom field value to menu class if it exists
 
 function a_starting_point_wp_nav_menu_objects( $items, $args ) {
 
 	$menu = $args->menu;
 
-	$custom_menu_class = get_field('asp_custom_menu_class', $menu);
-
-	if($custom_menu_class){
-			$args->menu_class .= ' '. a_starting_point_clean_acf_text_fields($custom_menu_class);
-	}
-
-  // loop
-	foreach( $items as &$item ) {
-
-		// vars
-		$icon = get_field('icon', $item);
-		$hide_text = get_field('hide_text', $item);
-
-
-		// append icon
-		if( $icon ) {
-
-      ( $hide_text ) ? $item->title = '<i class="'.$icon.'"></i>' : $item->title = '<i class="fas fa-'.$icon.'"></i> '. $item->title;
-
-		}
+	$a_starting_point_custom_menu_class = get_field('asp_custom_menu_class', $menu);
 
+	if($a_starting_point_custom_menu_class){
+			$args->menu_class .= ' '. a_starting_point_clean_acf_text_fields($a_starting_point_custom_menu_class);
 	}
 
 	return $items;

inc/acf-json/group_5c97a8b57f2bf.json

@@ -108,7 +108,7 @@ function a_starting_point_customize_partial_blogdescription() {
  * Binds JS handlers to make Theme Customizer preview reload changes asynchronously.
  */
 function a_starting_point_customize_preview_js() {
-	wp_enqueue_script( 'asp-theme-customizer', get_template_directory_uri() . '/customizer.js', array( 'customize-preview' ), '20151215', true );
+	wp_enqueue_script( 'asp-theme-customizer', get_template_directory_uri() . '/js/customizer.js', array( 'customize-preview' ), '20151215', true );
 }
 add_action( 'customize_preview_init', 'a_starting_point_customize_preview_js' );
 

inc/customizer.php

@@ -14,14 +14,12 @@
 	function a_starting_point_posted_on() {
 		$time_string = '<time class="entry-date published updated" datetime="%1$s">%2$s</time>';
 		if ( get_the_time( 'U' ) !== get_the_modified_time( 'U' ) ) {
-			$time_string = '<time class="entry-date published" datetime="%1$s">%2$s</time><time class="updated" datetime="%3$s">%4$s</time>';
+			$time_string = '<time class="entry-date published" datetime="%1$s">%2$s</time>';
 		}
 
 		$time_string = sprintf( $time_string,
 			esc_attr( get_the_date( DATE_W3C ) ),
-			esc_html( get_the_date() ),
-			esc_attr( get_the_modified_date( DATE_W3C ) ),
-			esc_html( get_the_modified_date() )
+			esc_html( get_the_date() )
 		);
 
 		$posted_on = sprintf(