Commit e51131e
docs(kotlin-sdk): correct the drain-scope note on buildSignedPayment
Two errors in the paragraph added by the previous commit, both caught in
review.
It linked to `CoreTransactionBuilder.AccountType` and offered a CoinJoin
sweep as the single-family example. But `buildSignedPayment` takes
`ManagedPlatformWallet.AccountType`, whose only variants are BIP44, BIP32
and ALL_SPENDABLE -- there is no CoinJoin variant, so the advice named a
scope the method cannot express. It now references the method's own enum
and offers BIP44 / BIP32, noting that a CoinJoin sweep goes through the
dedicated send-all path.
It also said change returns to BIP44. That is true of pooled funding in
general and false of a drain, which is the one case the paragraph is
about: `SelectionStrategy.ALL` leaves no change at all. Saying otherwise
contradicts the reason a drain needs documenting -- no change means no
wallet-owned output.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 5148368 commit e51131e
1 file changed
Lines changed: 12 additions & 9 deletions
File tree
- packages/kotlin-sdk/sdk/src/main/kotlin/org/dashfoundation/dashsdk/wallet
packages/kotlin-sdk/sdk/src/main/kotlin/org/dashfoundation/dashsdk/wallet/ManagedPlatformWallet.kt
Lines changed: 12 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
386 | 386 | | |
387 | 387 | | |
388 | 388 | | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
397 | | - | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
398 | 401 | | |
399 | 402 | | |
400 | 403 | | |
| |||
0 commit comments