Skip to content

multiple incompatible find_tile_file functions #189

Description

@sbailey

desisurvey has two different find_tile_file functions with different logic:

  • desisurvey.tiles.find_tile_file
    • file in $DESISURVEY_OUTPUT trumps other versions
    • Used by the Tiles object to set self.tiles_file
  • desisurvey.scripts.afternoon_plan.find_tile_file
    • does not use $DESISURVEY_OUTPUT
    • used in desisurvey.scripts.afternoon_plan.afternoon_plan, but maybe later superseded by a call to tiles.get_tiles which might set config state that overrides that version?

@schlafly it looks like you last touched this logic in issue #132. Could you take a look at this?

Context: I'm updating desisurvey for numpy/2 support and removing deprecation warnings, so I was checking test coverage first to make sure I didn't introduce an untested typo to ops code. But then I noticed the double definition ...

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status
Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions