Skip to content

Commit ff95fcb

Browse files
committed
Correct the root-cause explanation for the Codecov key-import failure.
The previous commit's comment cited codecov/codecov-action#1955 and its dead codecovsecurity Keybase URL as the direct cause. Checked dist/codecov.sh at our pinned SHA (v7.0.0) directly: it actually fetches from a different host, codecovsecops, which resolves fine with a valid key when checked directly right now. So the failures observed here (twice, before this fix) are better explained as a transient failure somewhere in that external key-retrieval path, not the same dead URL from #1955 -- similar class of problem, not the same bug. Trimmed the in-file comment to the essentials; the full detail lives in the PR description and commit history instead of duplicated inline.
1 parent 3dc764f commit ff95fcb

1 file changed

Lines changed: 5 additions & 9 deletions

File tree

.github/workflows/main.yaml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,9 @@ jobs:
8585
files: ./coverage/lcov.info
8686
fail_ci_if_error: true
8787
token: ${{ secrets.CODECOV_TOKEN }}
88-
# codecov/codecov-action#1955: the action's default CLI download path
89-
# verifies a GPG signature against a key fetched from
90-
# https://keybase.io/codecovsecurity/pgp_keys.asc, which has been
91-
# returning 404 since ~2026-06-06 -- an upstream Codecov outage, not
92-
# anything specific to this repo. `use_pypi` sources the CLI from
93-
# PyPI instead, skipping the broken key-import step entirely; this is
94-
# the maintainer-confirmed workaround (still needed as of this commit
95-
# even on the latest action version, v7.0.0). Safe to remove once
96-
# Codecov restores the Keybase key.
88+
# Works around intermittent "Can't check signature: No public key"
89+
# failures on the action's default GPG-verified CLI download (see
90+
# codecov/codecov-action#1955 for the same class of issue). Installs
91+
# the CLI from PyPI instead, which skips that verification -- an
92+
# availability fix, not a security-neutral one.
9793
use_pypi: true

0 commit comments

Comments
 (0)