fix: resolve CI failures in xtend migration

- Fix compilation error: replace EcoreFactory.createEObject() with
  new Object() for abstract/interface EClasses
- Remove unused imports (EObject, EcoreFactory) from EClassXtendType
- Add missing Javadoc on public constructors (checkstyle JavadocMethod)
- Fix PMD MethodReturnsInternalArray in EmfRegistryMetaModel
- Fix catch block: add final parameter, proper CHECKSTYLE suppression
- Remove unused context parameter from ExpressionAnalyzer.analyzeString
- Remove unused PrimitiveXtendType import from CompilationContextTest

https://claude.ai/code/session_01F7hkXr9MCMGnAMhMDmTd3W

Author: claude

com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/generator/ExportGeneratorSupport.java

@@ -53,6 +53,12 @@ public CompilationContext getCompilationContext(final ExportModel model, final G
    */
   private static class ExportExecutionContext extends DefaultXtendExecutionContext {
 
+    /**
+     * Creates a new execution context for the given export model.
+     *
+     * @param model
+     *          the export model
+     */
     ExportExecutionContext(final ExportModel model) {
       super();
       registerMetaModels(model);

com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/CompilationContext.java

@@ -66,7 +66,7 @@ public XtendType analyze(final Expression expression) {
    * @return type of expression
    */
   public XtendType analyze(final String expression) {
-    return ExpressionAnalyzer.analyzeString(expression, context);
+    return ExpressionAnalyzer.analyzeString(expression);
   }
 
   /**

com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/type/EClassXtendType.java

@@ -15,9 +15,7 @@
 import java.util.List;
 
 import org.eclipse.emf.ecore.EClass;
-import org.eclipse.emf.ecore.EObject;
 import org.eclipse.emf.ecore.EOperation;
-import org.eclipse.emf.ecore.EcoreFactory;
 
 
 /**
@@ -28,6 +26,12 @@ public class EClassXtendType implements XtendType {
 
   private final EClass eClass;
 
+  /**
+   * Creates a new type backed by the given EClass.
+   *
+   * @param eClass
+   *          the EClass
+   */
   public EClassXtendType(final EClass eClass) {
     this.eClass = eClass;
   }
@@ -49,7 +53,7 @@ public String getName() {
   @Override
   public Object newInstance() {
     if (eClass.isAbstract() || eClass.isInterface()) {
-      return EcoreFactory.eINSTANCE.createEObject();
+      return new Object();
     }
     return eClass.getEPackage().getEFactoryInstance().create(eClass);
   }
@@ -77,6 +81,12 @@ public boolean isAssignableFrom(final XtendType other) {
   private static class EOperationXtendOperation implements XtendOperation {
     private final EOperation operation;
 
+    /**
+     * Creates a new wrapper for the given EOperation.
+     *
+     * @param operation
+     *          the EOperation
+     */
     EOperationXtendOperation(final EOperation operation) {
       this.operation = operation;
     }

com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/type/EmfRegistryMetaModel.java

@@ -10,6 +10,8 @@
  *******************************************************************************/
 package com.avaloq.tools.ddk.xtext.expression.generator.type;
 
+import java.util.Arrays;
+
 import org.eclipse.emf.ecore.EClass;
 import org.eclipse.emf.ecore.EClassifier;
 import org.eclipse.emf.ecore.EPackage;
@@ -34,7 +36,7 @@ public class EmfRegistryMetaModel {
    *          the EMF packages
    */
   public EmfRegistryMetaModel(final EPackage... packages) {
-    this.packages = packages;
+    this.packages = Arrays.copyOf(packages, packages.length);
   }
 
   /**
@@ -43,7 +45,7 @@ public EmfRegistryMetaModel(final EPackage... packages) {
    * @return the packages
    */
   public EPackage[] allPackages() {
-    return packages;
+    return Arrays.copyOf(packages, packages.length);
   }
 
   /**

com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/type/ExpressionAnalyzer.java

@@ -74,11 +74,9 @@ public static XtendType analyze(final Expression expression, final XtendExecutio
    *
    * @param expression
    *          the expression string
-   * @param context
-   *          the execution context for type resolution
    * @return the inferred type
    */
-  public static XtendType analyzeString(final String expression, final XtendExecutionContext context) {
+  public static XtendType analyzeString(final String expression) {
     if (expression == null || expression.isEmpty()) {
       return PrimitiveXtendType.OBJECT;
     }

com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/type/PrimitiveXtendType.java

@@ -40,6 +40,14 @@ public class PrimitiveXtendType implements XtendType {
   private final String name;
   private final Class<?> javaType;
 
+  /**
+   * Creates a new primitive type with the given name and Java class.
+   *
+   * @param name
+   *          the type name
+   * @param javaType
+   *          the corresponding Java class
+   */
   public PrimitiveXtendType(final String name, final Class<?> javaType) {
     this.name = name;
     this.javaType = javaType;
@@ -72,9 +80,11 @@ public Object newInstance() {
     }
     try {
       return javaType.getDeclaredConstructor().newInstance();
-    } catch (Exception e) { // NOPMD CHECKSTYLE:OFF
+      // CHECKSTYLE:OFF
+    } catch (final Exception e) { // NOPMD
       return new Object();
-    } // CHECKSTYLE:ON
+    }
+    // CHECKSTYLE:ON
   }
 
   @Override

com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/type/XtendVariable.java

@@ -20,6 +20,14 @@ public class XtendVariable {
   private final String name;
   private final Object value;
 
+  /**
+   * Creates a new variable with the given name and value.
+   *
+   * @param name
+   *          the variable name
+   * @param value
+   *          the variable value
+   */
   public XtendVariable(final String name, final Object value) {
     this.name = name;
     this.value = value;

com.avaloq.tools.ddk.xtext.generator.test/src/com/avaloq/tools/ddk/xtext/generator/expression/CompilationContextTest.java

@@ -17,7 +17,6 @@
 
 import com.avaloq.tools.ddk.xtext.expression.generator.CompilationContext;
 import com.avaloq.tools.ddk.xtext.expression.generator.type.DefaultXtendExecutionContext;
-import com.avaloq.tools.ddk.xtext.expression.generator.type.PrimitiveXtendType;
 import com.avaloq.tools.ddk.xtext.expression.generator.type.XtendExtension;
 import com.avaloq.tools.ddk.xtext.expression.generator.type.XtendType;
 

com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/generator/ScopingGeneratorUtil.java

@@ -77,6 +77,12 @@ private static class ScopeExecutionContext extends DefaultXtendExecutionContext
 
     private static final String VAR_ORIGINAL_RESOURCE = "originalResource"; //$NON-NLS-1$
 
+    /**
+     * Creates a new execution context for the given scope model.
+     *
+     * @param model
+     *          the scope model
+     */
     ScopeExecutionContext(final ScopeModel model) {
       super(getVariables(model));
       registerMetaModels(model);