Skip to content

Enhancement: Support setting PB2NC_QUALITY_MARK_THRESH as a threshold #3189

Description

@JohnHalleyGotway

Describe the Enhancement

dtcenter/MET#3307 enhances PB2NC so that the quality_mark_thresh configuration option can be set as a threshold, instead of as an integer previously. The change is backward compatible so that setting either as a threshold (new) or integer (existing) works fine. Although setting as a threshold (e.g. <=2||==9) provides improved configurability. This issue is to enhance the METplus PB2NC wrapper to handle this change.

When considering the implementation options:

  • Ensure that setting it as a threshold works fine.
  • Recommend that existing conf files that set it as an integer continue to work. Could either pass the integer through to MET or translate PB2NC_QUALITY_MARK_THRESH = n into PB2NC_QUALITY_MARK_THRESH = <=n... whichever is more convenient.

Time Estimate

2 hours?

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Recommend including in the beta1 dev cycle to accompany the change in MET.

Funding Source

2025 NOAA METplus Software

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METplus-Wrappers-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METplus-Wrappers-X.Y.Z version, select the METplus-Wrappers-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions