Skip to content

Add error summary that is missing from the testing workflow log output #3204

Description

@hsoh-u

Replace italics below with details for this issue.

Describe the Enhancement

Provide a description of the enhancement request here.

The "Check for Differences" section of GHA "Testing" showed "ERROR SUMMARY" if the differences were detected. Now this is gone. It would nice to display the summary of differences. The new implementation shows the diff_log,zip is uploaded but it's not available to download.

For example, go to a result of GHA "Testing" https://github.com/dtcenter/MET/actions/runs/16128605103.
Click "Run Diff Tests in Docker"

Success
TIMING: Command took 06:11 (MM:SS): 'docker run --volumes-from met_truth -v /home/runner/work/MET/output:/data/output/met_test_output -v /home/runner/work/MET/diff:/data/output/met_test_diff -v /home/runner/work/MET/logs:/met/logs -v /home/runner/work/MET/MET:/met/MET -v /home/runner/work/MET/metplus:/metplus -e MET_REPO_DIR=/met/MET -e VERSION_EXT dtcenter/metplus-envs:diff.v6.1 bash -c "${MET_REPO_DIR}/.github/jobs/run_diff_tests.sh"'
ERROR: Differences exist in the output
Error: Process completed with exit code 1.

There is no ERROR SUMMARY.

Click "Upload logs as artifact"

Artifact logs_diff.zip successfully finalized. Artifact ID 3481261626
Artifact logs_diff has been successfully uploaded! Final size is 60172 bytes. Artifact ID is 3481261626
Artifact download URL: https://github.com/dtcenter/MET/actions/runs/16128605103/artifacts/3481261626

The download link does not work (got 404 error, page not found error).

Here is the previous behavior:
For example, go to a GHA instance, https://github.com/dtcenter/MET/actions/runs/15024339471 and click Check for Differences

**************
ERROR SUMMARY:
**************

COMPARING tc_stat/DIAGNOSTICS_stat.out
file1: /data/output/met_test_truth/tc_stat/DIAGNOSTICS_stat.out
file2: /data/output/met_test_output/tc_stat/DIAGNOSTICS_stat.out
ERROR: diff error:
10c10
< SUMMARY:  TK_ERR   OFCL    24    24 37.9953  22.94398 53.04663 35.64443   0 0        9.8341  30.9569  59.81688 68.59863 139.56233 49.98278 139.56233  911.88732     NA     NA        24       19        2 0.79167
---
> SUMMARY:  TK_ERR   OFCL    24    24 37.99531 22.94398 53.04663 35.64443   0 0        9.8341  30.9569  59.81688 68.59863 139.56233 49.98278 139.56233  911.88732     NA     NA        24       19        2 0.79167

End of script

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

NCAR base (2702701)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a MET-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a MET-X.Y.Z version, select the MET-X.Y Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y Development project for development toward the next coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions