Improve documentation of `mixin.perf.blast_search_trees`

[input-Here]

Checklist

• I am reporting a defect, not asking for help
• I have searched existing issues and this has not been reported
• I have reduced my mod list to the minimum required to reproduce this issue (see below)

Bug Description

I found #298 when searching existing issues, which is slightly different. They only experienced a problem when JEI was installed and when searching with namespaces. This issue occurs when mixin.perf.blast_search_trees is enabled but JEI or REI are not installed (I am creating a modpack which does not include either mod, but want people who install these on top of the modpack to be able to take advantage of the improvement).

I'm aware that versions <1.20.1 are considered "end of life" but I thought I would report this anyway, even if only to document it for others. I haven't tested 1.18.2 versions yet, where 5.18.0 is also the latest release; 1.19.2 versions appear to include some changes to this patch but I've also not tested if they fix this.

Minimal Mod List

• ModernFix 5.18.0+mc1.16.5 (error occurs on both Forge and Fabric versions)

Reproduction Steps

1. Create a new 1.16.5 Forge/Fabric instance with only ModernFix.
2. Enable mixin.perf.blast_search_trees in modernfix-mixins.properties
3. Launch the game and enter/create a Creative world
4. Open the Creative inventory and attempt to search for anything
5. See that no results appear

Diagnostic Info

latest.log

[input-Here]

Never mind, I misunderstood how this patch works. As I now understand it, the patch gets enabled automatically by ModernFix when JEI/REI is installed, not that the patch is only applicable when JEI/REI is installed (as I previously interpreted it). With hindsight that makes sense, but I think the wiki could be a bit more specific about this behaviour.

Separately, it appears that the patch is only enabled when JEI is installed, not when REI is installed. The wiki suggests it should apply when either mod is installed, but it seems the logic for applying the patch doesn't match this. Is this an error with the documentation?

[embeddedt]

As I now understand it, the patch gets enabled automatically by ModernFix when JEI/REI is installed, not that the patch is only applicable when JEI/REI is installed (as I previously interpreted it). With hindsight that makes sense, but I think the wiki could be a bit more specific about this behaviour.

This is true. Newer versions avoid this problem by requiring mixin.perf.blast_search_trees.force to be enabled if neither of the recipe viewer mods is available. That option is however currently not documented anywhere, partially to protect players from themselves.

Separately, it appears that the patch is only enabled when JEI is installed, not when REI is installed. The wiki suggests it should apply when either mod is installed, but it seems the logic for applying the patch doesn't match this. Is this an error with the documentation?

The wiki for 1.16 was wrong; the REI backend for that patch was only implemented later, in 1.18. Thanks for noticing that; I updated the page (although not sure how many people will read it).

---

I'll leave this issue open as a reminder to revisit the documentation for this feature. (I also discovered while investigating your report that the wiki page for 1.20 is currently very broken, and missing many options.)

[input-Here]

Thanks for the clarification on the patch. Glad to hear about wiki improvements too, I find it very useful personally.