From d88b5e82dd19a2d48384947c949ce77b7d254953 Mon Sep 17 00:00:00 2001 From: Raghu Betina Date: Mon, 19 Oct 2026 11:21:54 -0500 Subject: [PATCH] Expect NotFoundError for an unknown model OpenAI now answers an unknown model with a 404 (model_not_found) instead of a 400, so the edge-case example reported a false failure. It checks the error code in the body rather than the message text, because newer openai gem versions leave the body out of #message. --- examples/07_edge_cases.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/07_edge_cases.rb b/examples/07_edge_cases.rb index eb9f338..09b5c2f 100644 --- a/examples/07_edge_cases.rb +++ b/examples/07_edge_cases.rb @@ -17,11 +17,11 @@ chat.user("Hello") chat.generate! puts "✗ Should have raised an error" -rescue OpenAI::Errors::BadRequestError => e - if e.message.include?("does not exist") +rescue OpenAI::Errors::NotFoundError => e + if e.body.dig(:error, :code) == "model_not_found" puts "✓ Invalid model error correctly propagated" else - puts "✗ Error propagated but message unclear: #{e.message[0..80]}..." + puts "✗ Error propagated but code unclear: #{e.body.inspect[0..80]}..." end rescue => e puts "✗ Unexpected error type: #{e.class} - #{e.message[0..80]}..."