Commit 547b4c0
wuguofeng
fix(upgrade): set Accept header for GitHub asset download
GitHub release asset URLs are API endpoints
(api.github.com/repos/.../assets/XXX) that return JSON metadata by default,
not the binary. Without `Accept: application/octet-stream`, the downloaded
"archive" was actually JSON, causing tar extraction to fail with
"Could not find the required path in the archive".
self_update::ReleaseUpdate::update() sets this header internally; since we
bypass it and use Download directly, we must set it ourselves. Also adds a
User-Agent header (GitHub API requires one).1 parent 3315e05 commit 547b4c0
3 files changed
Lines changed: 29 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
205 | 226 | | |
206 | 227 | | |
207 | 228 | | |
| |||
0 commit comments