test(nextjs): Simplify grace-period wait in pages-router API route test

Author: logaretm

dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/api-route-transaction.test.ts

@@ -7,8 +7,9 @@ import { waitForTransaction } from '@sentry-internal/test-utils';
 test('Sends exactly one transaction for a pages-router API route', async ({ request }) => {
   const apiRouteTransactions: string[] = [];
 
-  // Never resolves; we accumulate every matching transaction and assert on the total after a grace period.
-  const collectorPromise = waitForTransaction('nextjs-pages-dir', transactionEvent => {
+  // Accumulate every matching transaction and assert on the total after a grace period. This predicate never
+  // returns true, so the promise never resolves; we just let it collect while we wait out the grace period.
+  void waitForTransaction('nextjs-pages-dir', transactionEvent => {
     if (transactionEvent?.transaction === 'GET /api/endpoint') {
       apiRouteTransactions.push(transactionEvent.contexts?.trace?.trace_id ?? '<no-trace-id>');
     }
@@ -18,7 +19,7 @@ test('Sends exactly one transaction for a pages-router API route', async ({ requ
   const response = await request.get('/api/endpoint');
   expect(await response.json()).toStrictEqual({ name: 'John Doe' });
 
-  await Promise.race([collectorPromise, new Promise(resolve => setTimeout(resolve, 6000))]);
+  await new Promise(resolve => setTimeout(resolve, 6000));
 
   expect(apiRouteTransactions).toHaveLength(1);
 });